From: Lan Tianyu <tianyu.lan@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, lenb@kernel.org,
jean-philippe.halimi@exascale-computing.eu,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
cpufreq@vger.kernel.org
Subject: Re: [PATCH 2/2 V2] CPUFreq: Add new sysfs attribute freqdomain_cpus for acpi-freq driver
Date: Thu, 27 Jun 2013 13:34:05 +0800 [thread overview]
Message-ID: <51CBCECD.6030106@intel.com> (raw)
In-Reply-To: <CAKohpokrU4LYGeL_oai+F1irHgk4y+KmO+71_MGVNOhEG6_QDw@mail.gmail.com>
On 2013年06月27日 13:24, Viresh Kumar wrote:
> On 26 June 2013 18:08, Lan Tianyu <tianyu.lan@intel.com> wrote:
>> diff --git a/Documentation/cpu-freq/acpi-cpufreq.txt b/Documentation/cpu-freq/acpi-cpufreq.txt
>> new file mode 100644
>> index 0000000..9c59d09
>> --- /dev/null
>> +++ b/Documentation/cpu-freq/acpi-cpufreq.txt
>> @@ -0,0 +1,7 @@
>> +Sysfs interface
>> +---------------------------
>> +(Interface locates in the directory /sys/devices/system/cpu/cpuN/cpufreq)
>> +
>> +freqdomain_cpus : List of Online + Offline CPUs in same CPU dependency
>> + domain.
>> +
>
> Apart from the comments from Rafael, this must be described a bit
> more. We must write here how is it different than related_cpus.
>
> Write: freqdomain_cpus are the list of cpus (online+offline) that share
> same clock/freq domain at hardware level. This information might
> be hidden from cpufreq core and so related_cpus can have different
> value compared to this. This is not used by kernel but userspace
> DVFS controllers to get better power/performance values for platforms
> using acpi-cpufreq.c driver.
>
Thanks for your comments. I will add this in my patch.
--
Best regards
Tianyu Lan
prev parent reply other threads:[~2013-06-27 5:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 12:38 [PATCH 2/2 V2] CPUFreq: Add new sysfs attribute freqdomain_cpus for acpi-freq driver Lan Tianyu
2013-06-27 0:10 ` Rafael J. Wysocki
2013-06-27 1:53 ` Lan Tianyu
2013-06-27 5:24 ` Viresh Kumar
2013-06-27 5:34 ` Lan Tianyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CBCECD.6030106@intel.com \
--to=tianyu.lan@intel.com \
--cc=cpufreq@vger.kernel.org \
--cc=jean-philippe.halimi@exascale-computing.eu \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.