From: "Suzuki K. Poulose" <suzuki@in.ibm.com>
To: Kevin Hao <haokexin@gmail.com>
Cc: linuxppc <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc: don't flush/invalidate the d/icache for an unknown relocation type
Date: Thu, 27 Jun 2013 12:06:33 +0530 [thread overview]
Message-ID: <51CBDD71.6030408@in.ibm.com> (raw)
In-Reply-To: <1372295383-19740-1-git-send-email-haokexin@gmail.com>
On 06/27/2013 06:39 AM, Kevin Hao wrote:
> For an unknown relocation type since the value of r4 is just the 8bit
> relocation type, the sum of r4 and r7 may yield an invalid memory
> address. For example:
> In normal case:
> r4 = c00xxxxx
> r7 = 40000000
> r4 + r7 = 000xxxxx
>
> For an unknown relocation type:
> r4 = 000000xx
> r7 = 40000000
> r4 + r7 = 400000xx
> 400000xx is an invalid memory address for a board which has just
> 512M memory.
>
> And for operations such as dcbst or icbi may cause bus error for an
> invalid memory address on some platforms and then cause the board
> reset. So we should skip the flush/invalidate the d/icache for
> an unknown relocation type.
>
Good catch. Thanks for the fix.
Acked-by: Suzuki K. Poulose <suzuki@in.ibm.com>
prev parent reply other threads:[~2013-06-27 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 1:09 [PATCH] powerpc: don't flush/invalidate the d/icache for an unknown relocation type Kevin Hao
2013-06-27 6:36 ` Suzuki K. Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CBDD71.6030408@in.ibm.com \
--to=suzuki@in.ibm.com \
--cc=haokexin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.