Re: [PATCH] xend: Fix xm list bug reporting incorrect memory size

["Marcos E. Matsunaga" <Marcos.Matsunaga@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]

Hi Matt,

I have corrected the tab problem and re-created the patch.

It is attached.

 From aec170275bef7f371d9a195f49a3e8790160dd0f Mon Sep 17 00:00:00 2001
From: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>
Date: Thu, 27 Jun 2013 05:25:42 -0400
Subject: [PATCH] xend: Fix xm list bug reporting incorrect memory size

This change allows xend to double-check the xcinfo info (which
hypercall it had already do) and use the up-to-date contents.

'xl' already does this by using the xcinfo.

Oracle-Bug: 14553104 ( MEM(K) IN XENTOP MISMATCH MEMTOTAL IN 
/PROC/MEMINFO AND MEM IN "XM LIST")
Signed-off-by: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
  tools/python/xen/xend/XendConfig.py | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/python/xen/xend/XendConfig.py 
b/tools/python/xen/xend/XendConfig.py
index 5568d35..eb433a7 100644
--- a/tools/python/xen/xend/XendConfig.py
+++ b/tools/python/xen/xend/XendConfig.py
@@ -1042,7 +1042,10 @@ class XendConfig(dict):
          @param dominfo: Domain information via xc.domain_getinfo()
          @type dominfo: dict
          """
-        self._dominfo_to_xapi(dominfo)
+        if dominfo['paused']:
+           self._dominfo_to_xapi(dominfo)
+        else:
+           self._dominfo_to_xapi(dominfo, update_mem = True)
          self.validate()

      def update_with_xenapi_config(self, xapi):
-- 
1.8.1.2


On 06/05/2013 03:01 PM, Matt Wilson wrote:
> This change allows xend to double-check the xcinfo info (which
> >hypercall it had already do) and use the up-to-date contents.
> >
> >'xl' already does this by using the xcinfo.
> >
> >Oracle-Bug: 14553104 ( MEM(K) IN XENTOP MISMATCH MEMTOTAL IN /PROC/MEMINFO AND MEM IN "XM LIST")
> >Signed-off-by: Marcos Matsunaga<Marcos.Matsunaga@oracle.com>
> >Signed-off-by: Konrad Rzeszutek Wilk<konrad.wilk@oracle.com>


[-- Attachment #2: 0001-xend-Fix-xm-list-bug-reporting-incorrect-memory-size.patch --]
[-- Type: text/x-patch, Size: 1364 bytes --]

>From aec170275bef7f371d9a195f49a3e8790160dd0f Mon Sep 17 00:00:00 2001
From: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>
Date: Thu, 27 Jun 2013 05:25:42 -0400
Subject: [PATCH] xend: Fix xm list bug reporting incorrect memory size

This change allows xend to double-check the xcinfo info (which
hypercall it had already do) and use the up-to-date contents.

'xl' already does this by using the xcinfo.

Oracle-Bug: 14553104 ( MEM(K) IN XENTOP MISMATCH MEMTOTAL IN /PROC/MEMINFO AND MEM IN "XM LIST")
Signed-off-by: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 tools/python/xen/xend/XendConfig.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/python/xen/xend/XendConfig.py b/tools/python/xen/xend/XendConfig.py
index 5568d35..eb433a7 100644
--- a/tools/python/xen/xend/XendConfig.py
+++ b/tools/python/xen/xend/XendConfig.py
@@ -1042,7 +1042,10 @@ class XendConfig(dict):
         @param dominfo: Domain information via xc.domain_getinfo()
         @type dominfo: dict
         """
-        self._dominfo_to_xapi(dominfo)
+        if dominfo['paused']:
+           self._dominfo_to_xapi(dominfo)
+        else:
+           self._dominfo_to_xapi(dominfo, update_mem = True)
         self.validate()
 
     def update_with_xenapi_config(self, xapi):
-- 
1.8.1.2


[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel