From: James Hogan <james.hogan@imgtec.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: yongbok.kim@imgtec.com, cristian.cuna@imgtec.com,
Leon Alrae <leon.alrae@imgtec.com>,
qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] hw/mips: align initrd to 64KB to avoid kernel error
Date: Thu, 27 Jun 2013 10:40:24 +0100 [thread overview]
Message-ID: <51CC0888.6030205@imgtec.com> (raw)
In-Reply-To: <CAFEAcA8aDx=p8atdcGskxXTgAQCJL3haceuaTiQRyLtHLH8yiw@mail.gmail.com>
On 27/06/13 09:12, Peter Maydell wrote:
> On 27 June 2013 08:35, Leon Alrae <leon.alrae@imgtec.com> wrote:
>> From: James Hogan <james.hogan@imgtec.com>
>>
>> The Linux kernel can be configured to use 64KB pages, but it also
>> requires initrd to be page aligned. Therefore, to be safe, align the
>> initrd to 64KB using a new INITRD_PAGE_MASK rather than
>> TARGET_PAGE_MASK.
>
> This is kind of similar to the ARM bug fixed in 98ed805c3.
> I wonder if we ought to have a per-CPU #define for "largest
> possible page alignment for this architecture" as well as
> "smallest possible" (the latter being TARGET_PAGE_MASK).
Yes, very similar. Although "largest possible" is probably quite Linux
specific so I'm not sure where it should really go (some arches support
pages up to 4MB and beyond, but obviously they're never used as basic
pages by Linux).
LINUX_MAXPAGE_MASK?
> This patch is a reasonable enough way to fix things though,
> so I'm not objecting to it.
>
> Aside: given the repetitive nature of the context hunks
> observable in this patch, it looks like it ought to be
> possible to abstract out some of the initrd/kernel load
> code from all those boards...
That thought did occur to me too :)
Cheers
James
next prev parent reply other threads:[~2013-06-27 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 7:35 [Qemu-devel] [PATCH] hw/mips: align initrd to 64KB to avoid kernel error Leon Alrae
2013-06-27 8:12 ` Peter Maydell
2013-06-27 9:40 ` James Hogan [this message]
2013-07-10 15:01 ` Leon Alrae
2013-07-24 16:24 ` Leon Alrae
2013-07-28 22:28 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC0888.6030205@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=cristian.cuna@imgtec.com \
--cc=leon.alrae@imgtec.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yongbok.kim@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.