From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-char: Fix ID reuse after chardev-remove for qapi-based init
Date: Thu, 27 Jun 2013 15:33:35 +0200 [thread overview]
Message-ID: <51CC3F2F.4090608@redhat.com> (raw)
In-Reply-To: <1372339512-28149-1-git-send-email-armbru@redhat.com>
On 06/27/13 15:25, Markus Armbruster wrote:
> Commit 2c5f488 introduced qapi-based character device initialization
> as a new code path in qemu_chr_new_from_opts(). Unfortunately, it
> failed to store parameter opts in the new chardev. Therefore,
> qemu_chr_delete() doesn't delete it. Even though the device is gone,
> its options linger, and any attempt to create another one with the
> same ID fails.
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
next prev parent reply other threads:[~2013-06-27 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 13:25 [Qemu-devel] [PATCH 1/1] qemu-char: Fix ID reuse after chardev-remove for qapi-based init Markus Armbruster
2013-06-27 13:33 ` Gerd Hoffmann [this message]
2013-07-01 13:14 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC3F2F.4090608@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.