From: Paolo Bonzini <pbonzini@redhat.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] KVM: VMX: Use proper types to access const arrays
Date: Thu, 27 Jun 2013 15:47:32 +0200 [thread overview]
Message-ID: <51CC4274.4000306@redhat.com> (raw)
In-Reply-To: <CA+rthh9-X8_Qe9egPPByFLsqF=NGDDNYLTNE3z8XjQA_-pHTjg@mail.gmail.com>
Il 27/06/2013 15:42, Mathias Krause ha scritto:
> > The "const int" is not particularly useful, but doesn't hurt either.
>
> It's more of a hint for the compiler to take the values verbatim
> instead of allocating stack space for them. But it'll probably already
> do it even without that "hint".
It won't change anything really. Maybe for "const int foo[]", but I'm
not even sure about that and it depends a lot on the circumstances (loop
unrolling, inlining, whether you ever store "foo" in a variable or pass
it as a parameter, ...). The compiler may leave it on the stack anyway.
Paolo
next prev parent reply other threads:[~2013-06-27 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 18:36 [PATCH 0/3] KVM: small type cleanups Mathias Krause
2013-06-26 18:36 ` [PATCH 1/3] KVM: VMX: Use proper types to access const arrays Mathias Krause
2013-06-27 13:33 ` Paolo Bonzini
2013-06-27 13:42 ` Mathias Krause
2013-06-27 13:47 ` Paolo Bonzini [this message]
2013-06-26 18:36 ` [PATCH 2/3] KVM: VMX: Use size_t to store sizeof() values Mathias Krause
2013-06-27 13:36 ` Paolo Bonzini
2013-06-26 18:36 ` [PATCH 3/3] KVM: x86: Drop useless cast Mathias Krause
2013-06-27 13:39 ` Paolo Bonzini
2013-07-11 7:43 ` [PATCH 0/3] KVM: small type cleanups Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC4274.4000306@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=minipli@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.