All of lore.kernel.org
 help / color / mirror / Atom feed
From: Siddharth Heroor <heroor@ti.com>
To: Denys Dmytriyenko <denys@ti.com>
Cc: "meta-ti@yoctoproject.org" <meta-ti@yoctoproject.org>
Subject: Re: [PATCH] recipes-kernel: Add GLSDK specific kernel tree for omap-a15
Date: Thu, 27 Jun 2013 20:01:22 +0530	[thread overview]
Message-ID: <51CC4CBA.2080109@ti.com> (raw)
In-Reply-To: <20130627142318.GK28379@edge>

On 6/27/2013 7:53 PM, Denys Dmytriyenko wrote:
>>> +
>>> +S = "${WORKDIR}/git"
>>> +
>>> +BRANCH = "master"
>>> +
>>> +# This commit corresponds to ti2013.04.02 release tag
>>
>> Sorry to nit-pick here, but any reason to re-use the tag name from the 
>> linux-ti-staging tree?  The reason I ask is back to it being confusing if I 
>> have two trees with the same tag name (including version) it becomes kind of 
>> confusing.  Especially since this tree is part of the same git.ti.com 
>> project as the other one.  Thoughts?
> 
> Currently, it's just an identical copy of our LCPD tree w/o any patches on 
> top, so it has the same tags and commit IDs...
> 
> One can argue though, if the trees are still the same, what's the reason to 
> create a new recipe so early in advance?

I want to get the basic recipes in place in time for the release. We do
have the option of submitting recipes post the release but I want to
avoid that.

Having the recipes in meta-ti ahead of time allows us to get feedback
_before_ we freeze.

> 
> 
>>> +SRCREV = "f3cb62a800ae37f17a3382b10d155ee02dbc83fc"
>>> +PV = "3.8.13"
>>> +
>>> +# Append to the MACHINE_KERNEL_PR so that a new SRCREV will cause
>>> a rebuild
>>> +MACHINE_KERNEL_PR_append = "f+gitr${SRCPV}"
>>
>> Go ahead and reset your append here to a+ gitr${SRCPV}.  No need to start 
>> from f.
>>
>> Thanks for the submission.  Overall looks pretty good, just a few things to 
>> fix up.
> 
> +1 keep up the good work!
> 



  reply	other threads:[~2013-06-27 14:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 10:13 [PATCH] recipes-kernel: Add GLSDK specific kernel tree for omap-a15 Siddharth Heroor
2013-06-27 12:14 ` Maupin, Chase
2013-06-27 13:34   ` Siddharth Heroor
2013-06-27 14:23   ` Denys Dmytriyenko
2013-06-27 14:31     ` Siddharth Heroor [this message]
2013-06-27 14:27   ` Siddharth Heroor
  -- strict thread matches above, loose matches on Subject: below --
2013-06-27 13:49 Siddharth Heroor
2013-06-27 13:52 ` Cooper Jr., Franklin
2013-06-27 14:16 ` Maupin, Chase

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CC4CBA.2080109@ti.com \
    --to=heroor@ti.com \
    --cc=denys@ti.com \
    --cc=meta-ti@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.