From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 4/8] ARM: OMAP: move cpuidle drivers to drivers/cpuidle/ Date: Thu, 27 Jun 2013 11:36:44 -0400 Message-ID: <51CC5C0C.2090505@ti.com> References: <1372241747-21083-1-git-send-email-b.zolnierkie@samsung.com> <1372241747-21083-5-git-send-email-b.zolnierkie@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1372241747-21083-5-git-send-email-b.zolnierkie@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Bartlomiej Zolnierkiewicz Cc: swarren@wwwdotorg.org, srinidhi.kasagar@stericsson.com, khilman@deeprootsystems.com, linus.walleij@linaro.org, nsekhar@ti.com, kgene.kim@samsung.com, daniel.lezcano@linaro.org, magnus.damm@gmail.com, tony@atomide.com, plagnioj@jcrosoft.com, Kevin Hilman , linux-pm@vger.kernel.org, nicolas.ferre@atmel.com, Rajendra Nayak , rjw@sisk.pl, horms@verge.net.au, ben-linux@fluff.org, linux@maxim.org.za, linux-arm-kernel@lists.infradead.org, "Kristo, Tero" , kyungmin.park@samsung.com, kernel@pengutronix.de, shawn.guo@linaro.org List-Id: linux-pm@vger.kernel.org (You have missed few CC's) +Kevin, Tero, Rajendra On Wednesday 26 June 2013 06:15 AM, Bartlomiej Zolnierkiewicz wrote: > While at it: > - remove file path from comment > - fix whitespace issues > > Compile tested only. > > Cc: Tony Lindgren > Cc: Daniel Lezcano > Cc: "Rafael J. Wysocki" > Signed-off-by: Kyungmin Park > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > arch/arm/mach-omap2/Makefile | 5 - > arch/arm/mach-omap2/cpuidle34xx.c | 344 ------------------------------------- > arch/arm/mach-omap2/cpuidle44xx.c | 217 ----------------------- > drivers/cpuidle/Makefile | 10 ++ > drivers/cpuidle/cpuidle-omap34xx.c | 342 ++++++++++++++++++++++++++++++++++++ > drivers/cpuidle/cpuidle-omap44xx.c | 216 +++++++++++++++++++++++ > 6 files changed, 568 insertions(+), 566 deletions(-) > delete mode 100644 arch/arm/mach-omap2/cpuidle34xx.c > delete mode 100644 arch/arm/mach-omap2/cpuidle44xx.c > create mode 100644 drivers/cpuidle/cpuidle-omap34xx.c > create mode 100644 drivers/cpuidle/cpuidle-omap44xx.c > [..] > diff --git a/drivers/cpuidle/cpuidle-omap44xx.c b/drivers/cpuidle/cpuidle-omap44xx.c > new file mode 100644 > index 0000000..86b8a51 > --- /dev/null > +++ b/drivers/cpuidle/cpuidle-omap44xx.c > @@ -0,0 +1,216 @@ > +/* > + * OMAP4+ CPU idle Routines > + * > + * Copyright (C) 2011-2013 Texas Instruments, Inc. > + * Santosh Shilimkar > + * Rajendra Nayak > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#include "../../arch/arm/mach-omap2/common.h" > +#include "../../arch/arm/mach-omap2/pm.h" > +#include "../../arch/arm/mach-omap2/prm.h" > +#include "../../arch/arm/mach-omap2/clockdomain.h" > + We have discussed it already on the list in past. The movement was pending exactly for above dependencies. I let Kevin take a call but moving drivers with such dependency with platform code is just not right. Regards, Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Thu, 27 Jun 2013 11:36:44 -0400 Subject: [PATCH 4/8] ARM: OMAP: move cpuidle drivers to drivers/cpuidle/ In-Reply-To: <1372241747-21083-5-git-send-email-b.zolnierkie@samsung.com> References: <1372241747-21083-1-git-send-email-b.zolnierkie@samsung.com> <1372241747-21083-5-git-send-email-b.zolnierkie@samsung.com> Message-ID: <51CC5C0C.2090505@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org (You have missed few CC's) +Kevin, Tero, Rajendra On Wednesday 26 June 2013 06:15 AM, Bartlomiej Zolnierkiewicz wrote: > While at it: > - remove file path from comment > - fix whitespace issues > > Compile tested only. > > Cc: Tony Lindgren > Cc: Daniel Lezcano > Cc: "Rafael J. Wysocki" > Signed-off-by: Kyungmin Park > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > arch/arm/mach-omap2/Makefile | 5 - > arch/arm/mach-omap2/cpuidle34xx.c | 344 ------------------------------------- > arch/arm/mach-omap2/cpuidle44xx.c | 217 ----------------------- > drivers/cpuidle/Makefile | 10 ++ > drivers/cpuidle/cpuidle-omap34xx.c | 342 ++++++++++++++++++++++++++++++++++++ > drivers/cpuidle/cpuidle-omap44xx.c | 216 +++++++++++++++++++++++ > 6 files changed, 568 insertions(+), 566 deletions(-) > delete mode 100644 arch/arm/mach-omap2/cpuidle34xx.c > delete mode 100644 arch/arm/mach-omap2/cpuidle44xx.c > create mode 100644 drivers/cpuidle/cpuidle-omap34xx.c > create mode 100644 drivers/cpuidle/cpuidle-omap44xx.c > [..] > diff --git a/drivers/cpuidle/cpuidle-omap44xx.c b/drivers/cpuidle/cpuidle-omap44xx.c > new file mode 100644 > index 0000000..86b8a51 > --- /dev/null > +++ b/drivers/cpuidle/cpuidle-omap44xx.c > @@ -0,0 +1,216 @@ > +/* > + * OMAP4+ CPU idle Routines > + * > + * Copyright (C) 2011-2013 Texas Instruments, Inc. > + * Santosh Shilimkar > + * Rajendra Nayak > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#include "../../arch/arm/mach-omap2/common.h" > +#include "../../arch/arm/mach-omap2/pm.h" > +#include "../../arch/arm/mach-omap2/prm.h" > +#include "../../arch/arm/mach-omap2/clockdomain.h" > + We have discussed it already on the list in past. The movement was pending exactly for above dependencies. I let Kevin take a call but moving drivers with such dependency with platform code is just not right. Regards, Santosh