Re: [PATCH 1/1] ARM: tegra: Add basic support for carma devkit

[Eric Brower <ebrower-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On 06/23/2013 06:38 AM, Chris Desjardins wrote:
>
> Signed-off-by: Chris Desjardins <chris.desjardins-8HJrC8Or5ylBDgjK7y7TUQ@public.gmane.org>
> ---
>   arch/arm/boot/dts/tegra30-carma.dts |  461 +++++++++++++++++++++++++++++++++++
>   1 file changed, 461 insertions(+)
>   create mode 100644 arch/arm/boot/dts/tegra30-carma.dts
>
> diff --git a/arch/arm/boot/dts/tegra30-carma.dts b/arch/arm/boot/dts/tegra30-carma.dts
> new file mode 100644
> index 0000000..e88134e
> --- /dev/null
> +++ b/arch/arm/boot/dts/tegra30-carma.dts
> @@ -0,0 +1,461 @@
> +/dts-v1/;
> +#include "tegra30.dtsi"
> +
> +/**
> + * This file contains common DT entry for Carma
> + */
> +
> +/ {
> +       model = "NVIDIA Tegra30 Carma evaluation board";
> +       compatible = "nvidia,carma", "nvidia,tegra30";

Chris,

This is not an NVIDIA board, it's a Seco board.  I'd suggest:

model = "Seco Tegra30 Carma development board";
compatible = "seco,carma", "nvidia,tegra30";

But you might want to check with Seco regarding preference of prefix for 
"seco,carma" above.  I see no precedent for it after a quick check.

Thanks,
Eric