From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39223)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1UsGvp-0001Lr-8S
	for qemu-devel@nongnu.org; Thu, 27 Jun 2013 14:28:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1UsGvo-0008SZ-HF
	for qemu-devel@nongnu.org; Thu, 27 Jun 2013 14:28:33 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:55073)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1UsGvo-0008SS-B8
	for qemu-devel@nongnu.org; Thu, 27 Jun 2013 14:28:32 -0400
Message-ID: <51CC844C.5090405@weilnetz.de>
Date: Thu, 27 Jun 2013 20:28:28 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1372177538-9812-1-git-send-email-cornelia.huck@de.ibm.com>
	<1372177538-9812-3-git-send-email-cornelia.huck@de.ibm.com>
In-Reply-To: <1372177538-9812-3-git-send-email-cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 2/3] virtio-ccw: Wire up ioeventfd.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, =?ISO-8859-15?Q?Aur=E9lien_Jarno?= <aurelien@aurel32.net>

Am 25.06.2013 18:25, schrieb Cornelia Huck:
> On hosts that support ioeventfd, make use of it for host-to-guest
> notifications via diagnose 500.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>  hw/s390x/css.c        |    2 +-
>  hw/s390x/css.h        |    1 +
>  hw/s390x/virtio-ccw.c |  117 +++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/s390x/virtio-ccw.h |    7 +++
>  target-s390x/cpu.h    |   16 +++++++
>  target-s390x/kvm.c    |   19 ++++++++
>  6 files changed, 161 insertions(+), 1 deletion(-)

This patch was recently committed to git master and breaks builds:

It uses event_notifier_get_fd which is only available for POSIX hosts.
W32/W64 uses event_notifier_get_handle.

Output from broken build:

   LINK  s390x-softmmu/qemu-system-s390xw.exe
hw/s390x/virtio-ccw.o: In function `virtio_ccw_set_guest2host_notifier':
hw/s390x/virtio-ccw.c:92: undefined reference to `event_notifier_get_fd'
hw/s390x/virtio-ccw.c:82: undefined reference to `event_notifier_get_fd'

Regards
Stefan Weil