Re: [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

On 06/27/2013 08:22 AM, Markus Armbruster wrote:
> Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER"
> assertion.  Broken in commit 1da48c65.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qemu-char.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 63972ae..63a9221 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -3108,7 +3108,7 @@ static void qemu_chr_parse_memory(QemuOpts *opts, ChardevBackend *backend,
>  
>      backend->memory = g_new0(ChardevMemory, 1);
>  
> -    val = qemu_opt_get_number(opts, "size", 0);
> +    val = qemu_opt_get_size(opts, "size", 0);
>      if (val != 0) {
>          backend->memory->has_size = true;
>          backend->memory->size = val;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]