From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Yao Subject: Re: [PATCH] fs: generic_file_llseek_size() should recognize invalid whence values Date: Thu, 27 Jun 2013 22:24:57 -0400 Message-ID: <51CCF3F9.5080500@gentoo.org> References: <1372386158-11076-1-git-send-email-ryao@gentoo.org> <1372386158-11076-3-git-send-email-ryao@gentoo.org> Reply-To: zfs-devel-VKpPRiiRko4/ohRxsw7f2g@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2BWWUAQPXDTWBGVAHVXPW" Cc: Alexander Viro , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org, zfs-devel-VKpPRiiRko4/ohRxsw7f2g@public.gmane.org To: Richard Yao Return-path: In-Reply-To: <1372386158-11076-3-git-send-email-ryao-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> List-Post: , List-Help: , List-Archive: List-Subscribe: , List-Unsubscribe: , List-Id: linux-fsdevel.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BWWUAQPXDTWBGVAHVXPW Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Please disregard this patch. This was in my outgoing folder from something that I had previously written, but it had no place being sent to the list (again). On 06/27/2013 10:22 PM, Richard Yao wrote: > generic_file_llseek_size() handles whence values in a switch statement,= > but it lacks cases for both SEEK_SET and invalid values. This causes it= > to treat all invalid whence values as SEEK_SET, which is wrong. >=20 > We fix that by adding a case for SEEK_SET and a default case. >=20 > Signed-off-by: Richard Yao > --- > fs/read_write.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/fs/read_write.c b/fs/read_write.c > index 0343000..54b8808 100644 > --- a/fs/read_write.c > +++ b/fs/read_write.c > @@ -81,6 +81,7 @@ generic_file_llseek_size(struct file *file, loff_t of= fset, int whence, > switch (whence) { > case SEEK_END: > offset +=3D eof; > + case SEEK_SET: > break; > case SEEK_CUR: > /* > @@ -118,6 +119,8 @@ generic_file_llseek_size(struct file *file, loff_t = offset, int whence, > return -ENXIO; > offset =3D eof; > break; > + default: > + return -EINVAL; > } > =20 > return lseek_execute(file, inode, offset, maxsize); >=20 ------enig2BWWUAQPXDTWBGVAHVXPW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRzPP/AAoJECDuEZm+6ExkF2AP/jgpEsji4GEU2qDocYOfvzeU YvKR2BkGHRgMj2EpRTdJJTRb25PdiHAG2+OiA0T+RaDA8PioWFQrFGGUVrRTbsE5 s9iWojD/yYjyB10vKcX90bBQguwL18HVit8dFCssSis4OStckNjSoW2ObiZ0bhZg dkLKxC94O5DQgVhgOEEajZoTV/7fEv5Po7W6CN0vS3Pe+A7pPaG/F0e4tcIHHs8x zq0KHRRqXWcI+J9lqKAiefoFczsxFR1cMpk1fzPAPrKjTykqJeApEFDj3a7FOWPS gKRc9RHJRJ8xwies+vYhhC1hc5nLVK49VSXsm8Hnr+Sc3V1xf2IHAv60V6rRvn/D 1zcKsUvw/hnCHm+zU4fpNrtb0x4O9HSWn3wRD468mzEHPyJ+d9wM9/FWjwqltLO6 cO13CXdv991DIxqCZeeusLOIr+Ds8nVzOs2a/OmrjgLdmNHuthttAIP5m3sdZ8xS /UV46k0tTZKAkRbPDWAyzxWbSYTBvo9VYVlEEAHdhXh0x3fiFY8Yq5BNQS2sMTiz lCpRTt3YtnhsLR82hWuj9I2FvPTwlIBI2j4rLYofvsjQB0RrVUkIcaEIl8lVtrZZ pbqAqqAKwSQLdfzqYEu5lhxuvDNwB1YKBd5++7q+uuPtUPn9uGnVHn80T1CKcvr1 2bsqUPdTXzujK7CHx6oR =+EQM -----END PGP SIGNATURE----- ------enig2BWWUAQPXDTWBGVAHVXPW--