From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Yao Subject: Re: [PATCH] fs: generic_file_llseek_size() should recognize invalid whence values Date: Thu, 27 Jun 2013 23:42:49 -0400 Message-ID: <51CD0639.2000703@gentoo.org> References: <1372386158-11076-1-git-send-email-ryao@gentoo.org> <1372386158-11076-3-git-send-email-ryao@gentoo.org> <20130628030959.GD4165@ZenIV.linux.org.uk> Reply-To: zfs-devel-VKpPRiiRko4/ohRxsw7f2g@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2GDMKJJNOVXFIERDQQXNL" Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org, zfs-devel-VKpPRiiRko4/ohRxsw7f2g@public.gmane.org To: Al Viro Return-path: In-Reply-To: <20130628030959.GD4165-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> List-Post: , List-Help: , List-Archive: List-Subscribe: , List-Unsubscribe: , List-Id: linux-fsdevel.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GDMKJJNOVXFIERDQQXNL Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06/27/2013 11:09 PM, Al Viro wrote: > On Thu, Jun 27, 2013 at 10:22:38PM -0400, Richard Yao wrote: >> generic_file_llseek_size() handles whence values in a switch statement= , >> but it lacks cases for both SEEK_SET and invalid values. This causes i= t >> to treat all invalid whence values as SEEK_SET, which is wrong. >> >> We fix that by adding a case for SEEK_SET and a default case. >=20 > NAK. Validation of whence is done before we even get to vfs_llseek(). > Leaving it to ->llseek() instances would've been an insanity. >=20 Agreed. That patch was written before I spotted that and was not meant to go out. It came along for the ride because my outgoing/ folder was dir= ty. ------enig2GDMKJJNOVXFIERDQQXNL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRzQZBAAoJECDuEZm+6ExkMAQP/1IP+KnGglS7h/Z72RBarzIZ e6ZBmFgRj4ujejC14yjbaC8rkfgg93uNyGSHDC36o9MLlwK07F0VwnoYclLLTEZW 5/d8LndXWcqCm7xEicROTi1vYcTVOepD9qRESwkkG0oOk4Os1jwH8TwTIrRmG3R0 nkslgJ8yIL9rrY/K6UirbaJXSUpTZqB7gR/XV54WjUJAMJf7QyH3dyHe0unVCahW U7/mvrAIqztuie1ZPgrgx3tFpK/bM4nl5OYoY9uMpSbW3UpfpbNpNOU1He3hkaio vE0bpopiRAdRwSBqdTsgdX94vQajgyRGZOso8az9VAwiQi2blWneS+ZnI0yO9ER8 mVFcYecjyOB7DBE7VPiVoI2QtGlLnM0gXA17ZS3dYNw34leULP5uI9M756xn58lN tvNfPj5k3HXixQm38hGLn+esiu57kP4xPl+e+IyJcqpUsfuIJwnWHt5GCTzloFYa rHs8W9ZfI448gO9BrJEb6iXzUJ5pJAL7JQk43QYeYG/1ywdiEBHhjwCRipugb/b/ Y0GO+6zQYoJ0pJNnH4RzhITvthtQQzzVlNDiHoDKYcc6TtOwT2gs79W0xPv7ySJ6 mk4FwhnscgqXPli46qoZcYxPDdt8SmpA0t65JLOsw85JzmBKton60Os5S9cqMJGL ALJv8kl9GeHeXvMgP6wb =OopQ -----END PGP SIGNATURE----- ------enig2GDMKJJNOVXFIERDQQXNL--