From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, sukadev@linux.vnet.ibm.com,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 8/8] powerpc/perf: Add power8 EBB support
Date: Fri, 28 Jun 2013 09:45:03 +0530 [thread overview]
Message-ID: <51CD0DC7.7020702@linux.vnet.ibm.com> (raw)
In-Reply-To: <1372333965.29229.26.camel@concordia>
On 06/27/2013 05:22 PM, Michael Ellerman wrote:
>
> On Wed, 2013-06-26 at 15:28 +0530, Anshuman Khandual wrote:
>>> @@ -117,6 +117,7 @@
>>> (EVENT_UNIT_MASK << EVENT_UNIT_SHIFT) | \
>>> (EVENT_COMBINE_MASK << EVENT_COMBINE_SHIFT) | \
>>> (EVENT_MARKED_MASK << EVENT_MARKED_SHIFT) | \
>>> + (1ull << EVENT_CONFIG_EBB_SHIFT) | \
>>
>> We should define this macro like EVENT_MARKED_MASK
>>
>> #define EVENT_EBB_MASK 0x1
>>
>> Numeric value of "1ull" stands out odd in the scheme.
>
> Yeah I guess.
>
> Would you like it in blue? :)
>
:) No, I meant probably a macro definition would be cool.
next prev parent reply other threads:[~2013-06-28 4:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 11:28 [PATCH 1/8] powerpc/perf: Check that events only include valid bits on Power8 Michael Ellerman
2013-06-24 11:28 ` [PATCH 2/8] powerpc/perf: Rework disable logic in pmu_disable() Michael Ellerman
2013-06-25 11:22 ` Anshuman Khandual
2013-06-26 3:28 ` Michael Ellerman
2013-07-10 0:15 ` Sukadev Bhattiprolu
2013-07-10 2:12 ` Michael Ellerman
2013-06-24 11:28 ` [PATCH 3/8] powerpc/perf: Freeze PMC5/6 if we're not using them Michael Ellerman
2013-06-24 11:28 ` [PATCH 4/8] powerpc/perf: Use existing out label in power_pmu_enable() Michael Ellerman
2013-06-27 11:01 ` Anshuman Khandual
2013-06-24 11:28 ` [PATCH 5/8] powerpc/perf: Don't enable if we have zero events Michael Ellerman
2013-06-28 5:10 ` Anshuman Khandual
2013-06-24 11:28 ` [PATCH 6/8] powerpc/perf: Drop MMCRA from thread_struct Michael Ellerman
2013-06-24 11:28 ` [PATCH 7/8] powerpc/perf: Core EBB support for 64-bit book3s Michael Ellerman
2013-06-26 8:38 ` Anshuman Khandual
2013-06-27 11:52 ` Michael Ellerman
2013-06-24 11:28 ` [PATCH 8/8] powerpc/perf: Add power8 EBB support Michael Ellerman
2013-06-26 9:58 ` Anshuman Khandual
2013-06-27 11:52 ` Michael Ellerman
2013-06-28 4:15 ` Anshuman Khandual [this message]
2013-07-04 18:58 ` Adhemerval Zanella
2013-07-05 2:54 ` Michael Ellerman
2013-07-05 17:57 ` Adhemerval Zanella
2013-06-25 10:55 ` [PATCH 1/8] powerpc/perf: Check that events only include valid bits on Power8 Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD0DC7.7020702@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.