From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsW4S-00017A-6H for qemu-devel@nongnu.org; Fri, 28 Jun 2013 06:38:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsW4Q-0005a8-U3 for qemu-devel@nongnu.org; Fri, 28 Jun 2013 06:38:28 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:52209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsW4Q-0005a1-Nf for qemu-devel@nongnu.org; Fri, 28 Jun 2013 06:38:26 -0400 Message-ID: <51CD67A1.2050509@msgid.tls.msk.ru> Date: Fri, 28 Jun 2013 14:38:25 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru> In-Reply-To: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Anthony Liguori , "Todd T. Fries" , qemu-devel@nongnu.org Ping? 19.06.2013 16:34, Michael Tokarev wrote: > It looks like initially there was -nographic option to turn > off display, now there's another option of the same sort, > -display none. But code in other places of qemu checks for > DT_NOGRAPHIC and does not work well with -display none. > Make DT_NOGRAPHIC an internal version which selects DT_NONE, > and check for that in all other places where previously we > checked for DT_NOGRAPHIC. > > While at it, rename two private variants of display (DT_DEFAULT > and DT_NOGRAPHIC) to use two underscores and make them negative, > and set DT_NONE to 0. > > This should fix the issue of non-working sun serial console > with the suggested replacement of -nographic which is > -display none. > > I'm not still sure we really want to check for display type > in qemu-char.c where we allow/disallow signals delivery from > terminal, -- for other display types (CURSES) this makes no > good sense. > > If the fix is correct, it is a stable material. > > Cc: Todd T. Fries > Signed-off-by: Michael Tokarev > --- > hw/lm32/milkymist-hw.h | 2 +- > hw/nvram/fw_cfg.c | 2 +- > hw/sparc/sun4m.c | 2 +- > include/sysemu/sysemu.h | 6 +++--- > qemu-char.c | 4 ++-- > vl.c | 15 +++++++-------- > 6 files changed, 15 insertions(+), 16 deletions(-) []