Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

[Sujit Reddy Thumma <sthumma@codeaurora.org>]

On 6/27/2013 4:49 PM, Santosh Y wrote:
>> >+       spin_lock_irqsave(host->host_lock, flags);
>> >         task_req_descp = hba->utmrdl_base_addr;
>> >         task_req_descp += free_slot;
>> >
>> >@@ -2353,38 +2387,39 @@ ufshcd_issue_tm_cmd(struct ufs_hba *hba,
>> >                 (struct utp_upiu_task_req *) task_req_descp->task_req_upiu;
>> >         task_req_upiup->header.dword_0 =
>> >                 UPIU_HEADER_DWORD(UPIU_TRANSACTION_TASK_REQ, 0,
>> >-                                             lrbp->lun, lrbp->task_tag);
>> >+                               lun_id, free_slot);
> Actually it still doesn't fix the problem. The*task tag*  used here
> should be unique across the SCSI/Query and Task Managment UPIUs.

I am sorry, I didn't get that. Why should it be unique across the 
SCSI/Query? For example, if a machine supports 32 request slots and 8 
task management slots, then the task management command tag can be 
anything out of 8 slots.

-- 
Regards,
Sujit