From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsX7Q-0002Cw-MT for qemu-devel@nongnu.org; Fri, 28 Jun 2013 07:45:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsX7P-000391-Es for qemu-devel@nongnu.org; Fri, 28 Jun 2013 07:45:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33437 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsX7P-00038q-6I for qemu-devel@nongnu.org; Fri, 28 Jun 2013 07:45:35 -0400 Message-ID: <51CD775A.3070006@suse.de> Date: Fri, 28 Jun 2013 13:45:30 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru> <51CD73A4.2050107@msgid.tls.msk.ru> In-Reply-To: <51CD73A4.2050107@msgid.tls.msk.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Peter Maydell , Anthony Liguori , "Todd T. Fries" , qemu-devel@nongnu.org Am 28.06.2013 13:29, schrieb Michael Tokarev: > 28.06.2013 15:24, Peter Maydell wrote: >> On 19 June 2013 13:34, Michael Tokarev wrote: >>> It looks like initially there was -nographic option to turn >>> off display, now there's another option of the same sort, >>> -display none. But code in other places of qemu checks for >>> DT_NOGRAPHIC and does not work well with -display none. >>> Make DT_NOGRAPHIC an internal version which selects DT_NONE, >>> and check for that in all other places where previously we >>> checked for DT_NOGRAPHIC. >>> >>> While at it, rename two private variants of display (DT_DEFAULT >>> and DT_NOGRAPHIC) to use two underscores and make them negative, >>> and set DT_NONE to 0. >>> >>> This should fix the issue of non-working sun serial console >>> with the suggested replacement of -nographic which is >>> -display none. >> >> Note that "-display none" and "-nographic" aren't exactly >> equivalent -- the latter is an option which turns on a bunch >> of behaviour including but not limited to "-display none". >=20 > Exactly. See ab51b1d568e02c80b1abf9016bda3a86dc1db389 > for a bit more context of this. >=20 >>> I'm not still sure we really want to check for display type >>> in qemu-char.c where we allow/disallow signals delivery from >>> terminal, -- for other display types (CURSES) this makes no >>> good sense. >> >> ...in particular I don't think "-display none" should >> mean "don't allow ctrl-c" (though -nographic should >> continue to have that effect), and this patch currently >> introduces that behaviour change. >=20 > As Anthony said before, -nographic is legacy. So there should > be some more modern way to control this. That's exactly the > change which I don't like myself. =20 > But "don't allow ctrl-c" > which is currently bound to -nographic is equally wrong. What's wrong about that? Isn't Ctrl+C passed through to the guest in -nographic mode? I don't see how any other mode inclusing daemonize would need that. Andreas >=20 >>> + DT__DEFAULT =3D -1, /* private */ >> I think these could use a slightly longer comment than just "private", >> eg "private, used internally by vl.c only". >=20 > Okay. >=20 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg