Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Add non-kvm stub file

[Paolo Bonzini <pbonzini@redhat.com>]

Il 28/06/2013 13:56, Alexander Graf ha scritto:
> 
> On 28.06.2013, at 13:54, Alexander Graf wrote:
> 
>> There are cases where a kvm provided function is called from generic
>> hw code that doesn't know whether kvm is available or not. Provide
>> a stub file which can provide simple replacement functions for those
>> cases.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
> 
> This by itself looks quite meager. I want to prepend this to the openpic kvm patch and squash the following chunk into that one to fix broken compilation on non-ppc systems:
> 
> 
> diff --git a/target-ppc/kvm-stub.c b/target-ppc/kvm-stub.c
> index 0f5c27d..ee3f5d2 100644
> --- a/target-ppc/kvm-stub.c
> +++ b/target-ppc/kvm-stub.c
> @@ -10,3 +10,9 @@
>   *
>   */
>  #include "qemu-common.h"
> +#include "hw/ppc/openpic.h"
> +
> +int kvm_openpic_connect_vcpu(DeviceState *d, CPUState *cs)
> +{
> +    return -EINVAL;
> +}
> 

Yup,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>