All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: st: Fix checking return value of syscon_regmap_lookup_by_phandle()
Date: Fri, 28 Jun 2013 14:56:14 +0100	[thread overview]
Message-ID: <51CD95FE.6070205@st.com> (raw)
In-Reply-To: <CAFRkauBbajREymRRZ8rbB6nzw4KgPWSd684Qz75MekcLzpoR=g@mail.gmail.com>

On 28/06/13 13:16, Axel Lin wrote:
> 2013/6/28 Srinivas KANDAGATLA <srinivas.kandagatla@st.com>:
>> Thankyou Axel for looking at this.
>>
>> There is already a patch is submitted for this.
>> https://lkml.org/lkml/2013/6/26/494 which I have Acked.
> 
> That is strange.
> I don't think the patch you mentioned can be applied to current pinctrl tree.
> Current code does check pinctrl_register by IS_ERR.
The patch removes the IS_ERR, because, pinctrl_register returns NULL or
a valid pointer, using IS_ERR is this case is incorrect.

Thanks,
srini
> 
>         info->pctl = pinctrl_register(pctl_desc, &pdev->dev, info);
>         if (IS_ERR(info->pctl)) {

> 
> Regards,
> Axel
> 


  reply	other threads:[~2013-06-28 14:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 10:33 [PATCH] pinctrl: st: Fix checking return value of syscon_regmap_lookup_by_phandle() Axel Lin
2013-06-28 10:36 ` Srinivas KANDAGATLA
2013-06-28 12:16   ` Axel Lin
2013-06-28 13:56     ` Srinivas KANDAGATLA [this message]
2013-06-28 14:24       ` Axel Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CD95FE.6070205@st.com \
    --to=srinivas.kandagatla@st.com \
    --cc=axel.lin@ingics.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.