All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: mxsfb: Break the line in videomode message
Date: Fri, 28 Jun 2013 16:57:44 +0200	[thread overview]
Message-ID: <51CDA468.2040204@denx.de> (raw)
In-Reply-To: <201306262156.05006.marex@denx.de>

Hi Fabio, hi Marek,

On 26/06/2013 21:56, Marek Vasut wrote:
> Dear Fabio Estevam,
> 
>> Currently we have the following on boot:
>>
>> CPU:   Freescale i.MX28 rev1.2 at 454 MHz
>> BOOT:  SSP SD/MMC #0, 3V3
>> DRAM:  128 MiB
>> MMC:   MXS MMC: 0
>> Video: MXSFB: 'videomode' variable not set!In:    serial
>>
>> Break the line of the warning message in order to have a better reading
>> format.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>>  drivers/video/mxsfb.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
>> index b189419..411d356 100644
>> --- a/drivers/video/mxsfb.c
>> +++ b/drivers/video/mxsfb.c
>> @@ -137,7 +137,7 @@ void *video_hw_init(void)
>>  	/* Suck display configuration from "videomode" variable */
>>  	penv = getenv("videomode");
>>  	if (!penv) {
>> -		printf("MXSFB: 'videomode' variable not set!");
>> +		printf("MXSFB: 'videomode' variable not set!\n");
> 
> puts() ... and you might want to fix it in all drivers ;-)
> 

That is correct - as it is a very small change, I fix it myself by
applying the patch.

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2013-06-28 14:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26 19:08 [U-Boot] [PATCH] video: mxsfb: Break the line in videomode message Fabio Estevam
2013-06-26 19:56 ` Marek Vasut
2013-06-28 14:57   ` Stefano Babic [this message]
2013-06-28 15:00     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CDA468.2040204@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.