From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtAtR-0001iU-2c for qemu-devel@nongnu.org; Sun, 30 Jun 2013 02:13:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtAtQ-0001zZ-1z for qemu-devel@nongnu.org; Sun, 30 Jun 2013 02:13:49 -0400 Message-ID: <51CFCC94.9030606@suse.de> Date: Sun, 30 Jun 2013 08:13:40 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1372556709-23868-1-git-send-email-agraf@suse.de> <1372556709-23868-9-git-send-email-agraf@suse.de> In-Reply-To: <1372556709-23868-9-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 08/32] kvm/openpic: in-kernel mpic support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Blue Swirl , Scott Wood , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Aurelien Jarno Am 30.06.2013 03:44, schrieb Alexander Graf: > From: Scott Wood >=20 > Enables support for the in-kernel MPIC that thas been merged into the > KVM next branch. This includes irqfd/KVM_IRQ_LINE support from Alex > Graf (along with some other improvements). >=20 > Note from Alex regarding kvm_irqchip_create(): >=20 > On x86, one would call kvm_irqchip_create() to initialize an > in-kernel interrupt controller. That function then goes ahead and > initializes global capability variables as well as the default irq > routing table. >=20 > On ppc, we can't call kvm_irqchip_create() because we can have > different types of interrupt controllers. So we want to do all the > things that function would do for us in the in-kernel device init > handler. >=20 > Signed-off-by: Scott Wood > [agraf: squash in kvm_irqchip_commit_routes patch, fix non-kvm build] > Signed-off-by: Alexander Graf > --- > default-configs/ppc-softmmu.mak | 1 + > default-configs/ppc64-softmmu.mak | 1 + > hw/intc/Makefile.objs | 1 + > hw/intc/openpic_kvm.c | 252 ++++++++++++++++++++++++++++++= ++++++++ > hw/ppc/e500.c | 79 +++++++++++- > include/hw/ppc/openpic.h | 2 +- > target-ppc/kvm-stub.c | 6 + > 7 files changed, 336 insertions(+), 6 deletions(-) > create mode 100644 hw/intc/openpic_kvm.c I had objected to the subject, and this patch is not bisectable since you didn't squash my ppcemb-softmmu build fix. Please do. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg