From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44252)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1UtBln-0006T8-Ac
	for qemu-devel@nongnu.org; Sun, 30 Jun 2013 03:10:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1UtBlm-00030H-GC
	for qemu-devel@nongnu.org; Sun, 30 Jun 2013 03:09:59 -0400
Received: from mail-pb0-f46.google.com ([209.85.160.46]:44081)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1UtBlm-0002zw-9k
	for qemu-devel@nongnu.org; Sun, 30 Jun 2013 03:09:58 -0400
Received: by mail-pb0-f46.google.com with SMTP id rq2so3690062pbb.5
	for <qemu-devel@nongnu.org>; Sun, 30 Jun 2013 00:09:56 -0700 (PDT)
Message-ID: <51CFD9BC.1020207@ozlabs.ru>
Date: Sun, 30 Jun 2013 17:09:48 +1000
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1372513521-10050-1-git-send-email-aik@ozlabs.ru>
	<CA+aC4ksLP8BX5WjVbEMpmdwMAcPrtDLpB9rJeZu6iLgwWyWvtA@mail.gmail.com>
	<51CF82D6.4000106@ozlabs.ru> <1372573929.18612.118.camel@pasglop>
In-Reply-To: <1372573929.18612.118.camel@pasglop>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] RFCv3 kvm irqfd: support
 msimessage to irq translation in PHB
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "Michael S . Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>, qemu-ppc@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Paul Mackerras <paulus@samba.org>, David Gibson <david@gibson.dropbear.id.au>

On 06/30/2013 04:32 PM, Benjamin Herrenschmidt wrote:
> On Sun, 2013-06-30 at 10:59 +1000, Alexey Kardashevskiy wrote:
>>> 1) A PCI bus function to do the MSI -> virq mapping
>>> 2) On x86 (and e500), this is implemented by calling kvm_irqchip_add_msi_route()
>>> 3) On pseries, this just returns msi->data
>>>
>>> Perhaps (2) can just be the default PCI bus implementation to simplify things.
>>
>>
>> hw/pci/pci.c does not have any kvm code yet and I would like not to be the
>> first person who tries adding this there :)
>> But ok, I'll do it.
> 
> Unless I'm confused (which is very possible) I seem to remember that there was
> duplication of that MSI / KVM mapping between virtio-pci and vfio as well,
> so it makes sense to move it to the PCI code.

No, you are right and this is what Anthony is telling me to do.


-- 
Alexey