All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Seyfried <stefan.seyfried@googlemail.com>
To: Wang YanQing <udknight@gmail.com>
Cc: stable <stable@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: commit 8d2f8cd424 breaks parallel port, regression since 3.9-rc3 / backported to stable (3.4.37)
Date: Sun, 30 Jun 2013 15:47:44 +0200	[thread overview]
Message-ID: <51D03700.1090709@message-id.googlemail.com> (raw)

Hi all,

the following commit:

commit 8d2f8cd424ca0b99001f3ff4f5db87c4e525f366
Author: Wang YanQing <udknight@gmail.com>
Date:   Fri Mar 1 11:47:20 2013 +0800

    serial: 8250_pci: add support for another kind of NetMos Technology PCI 9835 Multi-I/O Controller
    
    01:08.0 Communication controller: NetMos Technology PCI 9835 Multi-I/O Controller (rev 01)
        Subsystem: Device [1000:0012]
        Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
        Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
        Interrupt: pin A routed to IRQ 20
        Region 0: I/O ports at e050 [size=8]
        Region 1: I/O ports at e040 [size=8]
        Region 2: I/O ports at e030 [size=8]
        Region 3: I/O ports at e020 [size=8]
        Region 4: I/O ports at e010 [size=8]
        Region 5: I/O ports at e000 [size=16]
    
    Signed-off-by: Wang YanQing <udknight@gmail.com>
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


breaks my
05:05.0 Communication controller: NetMos Technology PCI 9835 Multi-I/O Controller (rev 01)
05:05.0 0780: 9710:9835 (rev 01)
        Subsystem: 1000:0012

which has two serial and one parallel port, driven by parport_serial.

The reason is, that this commit adds the PCI ID to 8250_pci, when it
was handled by parport_serial before.
In my case (openSUSE kernel), 8250 is built in and parport_serial is
built as a module. Unfortunately with the device occupied by 8250,
parport_serial finds no device and thus does not drive the parport.

I bisected this in the stable series after the openSUSE kernel update
(which pulled in the stable kernel update) broke my printing.

Actually the above commit is totally unnecessary: the serial ports
work very well without it, they are just driven by another driver.

Can this please be reverted? I can't see which problem it solves, but
it definitely breaks the additional ports on my multi-i/o board.

Best regards,

	Stefan
-- 
Stefan Seyfried
Linux Consultant & Developer -- GPG Key: 0x731B665B

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537

             reply	other threads:[~2013-06-30 13:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30 13:47 Stefan Seyfried [this message]
2013-06-30 16:02 ` commit 8d2f8cd424 breaks parallel port, regression since 3.9-rc3 / backported to stable (3.4.37) Greg Kroah-Hartman
2013-07-01  7:14   ` 8250_pci: improve code comments and Kconfig help stefan.seyfried
2013-07-01  7:14     ` [PATCH] " stefan.seyfried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D03700.1090709@message-id.googlemail.com \
    --to=stefan.seyfried@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=udknight@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.