From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not. Date: Mon, 01 Jul 2013 10:39:25 +0800 Message-ID: <51D0EBDD.70804@asianux.com> References: <51C548E2.1060104@asianux.com> <51C54A9B.9060009@asianux.com> <51CE9442.2020105@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Geert Uytterhoeven Cc: Michael Schmitz , linux-m68k , "linux-kernel@vger.kernel.org" , uClinux development list On 06/29/2013 04:26 PM, Geert Uytterhoeven wrote: > On Sat, Jun 29, 2013 at 10:01 AM, Michael Schmitz wrote: >>> >> The same .config file, also report the compiling error below: >>> >> >>> >> drivers/i2c/busses/i2c-ocores.c:81:2: error: implicit declaratio= n of >>> >> function =E2=80=98iowrite8=E2=80=99 [-Werror=3Dimplicit-function= -declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:86:2: error: implicit declaratio= n of >>> >> function =E2=80=98iowrite16=E2=80=99 [-Werror=3Dimplicit-functio= n-declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:91:2: error: implicit declaratio= n of >>> >> function =E2=80=98iowrite32=E2=80=99 [-Werror=3Dimplicit-functio= n-declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:96:2: error: implicit declaratio= n of >>> >> function =E2=80=98ioread8=E2=80=99 [-Werror=3Dimplicit-function-= declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:101:2: error: implicit declarati= on of >>> >> function =E2=80=98ioread16=E2=80=99 [-Werror=3Dimplicit-function= -declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:106:2: error: implicit declarati= on of >>> >> function =E2=80=98ioread32=E2=80=99 [-Werror=3Dimplicit-function= -declaration] >>> >> >>> >> Excuse me, I am not quite familiar with the related hardware and= m68k, >>> >> I guess under m68k architecture, we need not this drivers, is it= correct ? > Until someone synthesizes the OpenCores i2c core together with the > OpenCores 68000 core (they seem to have one), and tries to run uClinu= x > on it... >=20 OK, thanks. >> > That would be correct, yes. Perhaps add appropriate dependencies i= n >> > drivers/i2c/Kconfig to allow building I2C drivers >> > only on hardware that supports it? > We still want it for compile-coverage. >=20 > Now, the issue is that m68knommu doesn't implement ioread8() and > friends, so I'm adding the uClinux list. Do you also add it to main tree (e.g next-tree), if not, I recommend to do add it to main tree. Thanks. --=20 Chen Gang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223Ab3GACkS (ORCPT ); Sun, 30 Jun 2013 22:40:18 -0400 Received: from intranet.asianux.com ([58.214.24.6]:33755 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751705Ab3GACkR (ORCPT ); Sun, 30 Jun 2013 22:40:17 -0400 X-Spam-Score: -100.8 Message-ID: <51D0EBDD.70804@asianux.com> Date: Mon, 01 Jul 2013 10:39:25 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Michael Schmitz , linux-m68k , "linux-kernel@vger.kernel.org" , uClinux development list Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not. References: <51C548E2.1060104@asianux.com> <51C54A9B.9060009@asianux.com> <51CE9442.2020105@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29/2013 04:26 PM, Geert Uytterhoeven wrote: > On Sat, Jun 29, 2013 at 10:01 AM, Michael Schmitz wrote: >>> >> The same .config file, also report the compiling error below: >>> >> >>> >> drivers/i2c/busses/i2c-ocores.c:81:2: error: implicit declaration of >>> >> function ‘iowrite8’ [-Werror=implicit-function-declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:86:2: error: implicit declaration of >>> >> function ‘iowrite16’ [-Werror=implicit-function-declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:91:2: error: implicit declaration of >>> >> function ‘iowrite32’ [-Werror=implicit-function-declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:96:2: error: implicit declaration of >>> >> function ‘ioread8’ [-Werror=implicit-function-declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:101:2: error: implicit declaration of >>> >> function ‘ioread16’ [-Werror=implicit-function-declaration] >>> >> drivers/i2c/busses/i2c-ocores.c:106:2: error: implicit declaration of >>> >> function ‘ioread32’ [-Werror=implicit-function-declaration] >>> >> >>> >> Excuse me, I am not quite familiar with the related hardware and m68k, >>> >> I guess under m68k architecture, we need not this drivers, is it correct ? > Until someone synthesizes the OpenCores i2c core together with the > OpenCores 68000 core (they seem to have one), and tries to run uClinux > on it... > OK, thanks. >> > That would be correct, yes. Perhaps add appropriate dependencies in >> > drivers/i2c/Kconfig to allow building I2C drivers >> > only on hardware that supports it? > We still want it for compile-coverage. > > Now, the issue is that m68knommu doesn't implement ioread8() and > friends, so I'm adding the uClinux list. Do you also add it to main tree (e.g next-tree), if not, I recommend to do add it to main tree. Thanks. -- Chen Gang