From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vijay Purushothaman Subject: Re: [PATCH] drm/i915: Don't wait for vblank for sprite plane flips Date: Mon, 01 Jul 2013 10:58:06 +0530 Message-ID: <51D11366.1050202@intel.com> References: <1372428931-24144-1-git-send-email-vijay.a.purushothaman@intel.com> <20130628142450.GH5004@intel.com> <20130628160518.GD32183@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id C343DE5C82 for ; Sun, 30 Jun 2013 22:28:08 -0700 (PDT) In-Reply-To: <20130628160518.GD32183@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , =?ISO-8859-1?Q?Ville_Syrj=E4?= =?ISO-8859-1?Q?l=E4?= , Intel Graphics List-Id: intel-gfx@lists.freedesktop.org On 6/28/2013 9:35 PM, Chris Wilson wrote: > On Fri, Jun 28, 2013 at 05:24:50PM +0300, Ville Syrj=E4l=E4 wrote: >> On Fri, Jun 28, 2013 at 07:45:31PM +0530, Vijay Purushothaman wrote: >>> Since the sprite planes are using synchronized MMIO based flip, no need >>> to wait for vblank. Removing this wait allows us to get a nice >>> performance boost to both 3D & media workloads based on sprite (~60 fps >>> from ~20 fps) >> >> Nak. We can't unpin the buffer until the hardware has finished reading >> from it. >> >> The proper fix is to do the unpin asynchronously after the flip has >> completed. That's one part of the bigger atomic pageflip story. > > The interested reader is invited to review the patches to do async > unpinning here and in set-base sent many, many moons ago. > -Chris > Thanks Chris. I will try to dig for those patches. In case if you have = the pointers handy, would you mind pointing me to the patch series? Thanks, Vijay