Re: [PATCH 3/3] Btrfs-progs: remove unused code

[Anand Jain <Anand.Jain@oracle.com>]

good catch.

Reviewed-by: Anand Jain <anand.jain@oracle.com>


On 06/30/2013 07:51 PM, Filipe David Borba Manana wrote:
> The uuid_unparse() call in btrfs_scan_one_device() was
> a no-op.
>
>
> Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
> ---
>   volumes.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/volumes.c b/volumes.c
> index ea1d401..9d5e97e 100644
> --- a/volumes.c
> +++ b/volumes.c
> @@ -223,7 +223,6 @@ int btrfs_scan_one_device(int fd, const char *path,
>   	char *buf;
>   	int ret;
>   	u64 devid;
> -	char uuidbuf[37];
>
>   	buf = malloc(4096);
>   	if (!buf) {
> @@ -241,7 +240,6 @@ int btrfs_scan_one_device(int fd, const char *path,
>   		*total_devs = 1;
>   	else
>   		*total_devs = btrfs_super_num_devices(disk_super);
> -	uuid_unparse(disk_super->fsid, uuidbuf);
>
>   	ret = device_list_add(path, disk_super, devid, fs_devices_ret);
>
>