From: Seung-Woo Kim <sw0312.kim@samsung.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
dri-devel@lists.freedesktop.org, airlied@linux.ie,
kyungmin.park@samsung.com, yj44.cho@samsung.com,
Seung-Woo Kim <sw0312.kim@samsung.com>
Subject: Re: [PATCH 1/3] drm: fix print format of sequence in trace point
Date: Mon, 01 Jul 2013 19:28:49 +0900 [thread overview]
Message-ID: <51D159E1.60509@samsung.com> (raw)
In-Reply-To: <20130701102359.GD15843@cantiga.alporthouse.com>
Hello Chris,
Thank you for reviewing.
On 2013년 07월 01일 19:23, Chris Wilson wrote:
> On Mon, Jul 01, 2013 at 07:06:31PM +0900, Seung-Woo Kim wrote:
>> seq of a trace point is unsigned int but print format was %d. So
>> it fixes the format as %u even the format can be not used.
>
> I don't understand what you mean here. The patch itself looks fine.
I can not find where the format is used or not, so I think the format is
not really used anywhere. If you want to fix the commit-msg, I'll update
and re-send this patch.
Regards,
- Seung-Woo Kim
>
>> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
>
--
Seung-Woo Kim
Samsung Software R&D Center
--
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-07-01 10:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 10:06 [PATCH 0/3] drm: minor cleanups Seung-Woo Kim
2013-07-01 10:06 ` [PATCH 1/3] drm: fix print format of sequence in trace point Seung-Woo Kim
2013-07-01 10:23 ` Chris Wilson
2013-07-01 10:28 ` Seung-Woo Kim [this message]
2013-07-01 10:34 ` Chris Wilson
2013-07-01 10:44 ` [PATCH v2 " Seung-Woo Kim
2013-07-01 10:49 ` Chris Wilson
2013-07-01 10:06 ` [PATCH 2/3] drm: move edid null check to the first part of drm_edid_block_valid Seung-Woo Kim
2013-07-01 10:21 ` Chris Wilson
2013-07-01 14:56 ` Daniel Vetter
2013-07-01 23:54 ` Seung-Woo Kim
2013-07-02 0:11 ` [PATCH v3 3/3] drm: fix error routines in drm_open_helper Seung-Woo Kim
2013-07-02 0:52 ` [PATCH v2 2/3] drm: add assertion for checking null edid to drm_edid_block_valid Seung-Woo Kim
2013-07-02 8:29 ` Ville Syrjälä
2013-07-02 8:47 ` Seung-Woo Kim
2013-07-02 8:57 ` [PATCH v3 " Seung-Woo Kim
2013-07-02 11:22 ` Chris Wilson
2013-07-02 11:20 ` [PATCH v2 " Chris Wilson
2013-07-01 10:06 ` [PATCH 3/3] drm: fix error routines in drm_open_helper Seung-Woo Kim
2013-07-01 10:18 ` Chris Wilson
2013-07-01 10:49 ` [PATCH v2 " Seung-Woo Kim
2013-07-01 10:57 ` Chris Wilson
2013-07-01 11:14 ` Seung-Woo Kim
2013-07-01 11:52 ` Chris Wilson
2013-07-01 12:02 ` YoungJun Cho
2013-07-02 0:53 ` [PATCH v4 " Seung-Woo Kim
2013-07-02 11:19 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D159E1.60509@samsung.com \
--to=sw0312.kim@samsung.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=kyungmin.park@samsung.com \
--cc=yj44.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.