From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@ingics.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: adav80x: Add module device table for adav801
Date: Mon, 01 Jul 2013 14:16:06 +0200 [thread overview]
Message-ID: <51D17306.1080307@metafoo.de> (raw)
In-Reply-To: <1372668544.17974.1.camel@phoenix>
On 07/01/2013 10:49 AM, Axel Lin wrote:
> This driver can be built as module, thus add module device table for
> adav801 to support module auto loading.
>
> To make the naming consistent, also rename adav80x_id to adav80x_i2c_id.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> --- sound/soc/codecs/adav80x.c | 13 ++++++++++--- 1 file changed, 10
> insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/adav80x.c b/sound/soc/codecs/adav80x.c index
> 3c839cc..15b012d0 100644 --- a/sound/soc/codecs/adav80x.c +++
> b/sound/soc/codecs/adav80x.c @@ -868,6 +868,12 @@ static int
> adav80x_bus_remove(struct device *dev) }
>
> #if defined(CONFIG_SPI_MASTER) +static const struct spi_device_id
> adav80x_spi_id[] = { + { "adav801", 0 }, + { } +};
> +MODULE_DEVICE_TABLE(spi, adav80x_spi_id); + static int
> adav80x_spi_probe(struct spi_device *spi) { return
> adav80x_bus_probe(&spi->dev, SND_SOC_SPI); @@ -885,15 +891,16 @@ static
> struct spi_driver adav80x_spi_driver = { }, .probe = adav80x_spi_probe,
> .remove = adav80x_spi_remove, + .id_table = adav80x_spi_id, }; #endif
>
> #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) -static const struct
> i2c_device_id adav80x_id[] = { +static const struct i2c_device_id
> adav80x_i2c_id[] = { { "adav803", 0 }, { } }; -MODULE_DEVICE_TABLE(i2c,
> adav80x_id); +MODULE_DEVICE_TABLE(i2c, adav80x_i2c_id);
>
> static int adav80x_i2c_probe(struct i2c_client *client, const struct
> i2c_device_id *id) @@ -913,7 +920,7 @@ static struct i2c_driver
> adav80x_i2c_driver = { }, .probe = adav80x_i2c_probe, .remove =
> adav80x_i2c_remove, - .id_table = adav80x_id, + .id_table =
> adav80x_i2c_id, }; #endif
>
next prev parent reply other threads:[~2013-07-01 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 8:49 [PATCH] ASoC: adav80x: Add module device table for adav801 Axel Lin
2013-07-01 12:16 ` Lars-Peter Clausen [this message]
2013-07-02 9:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D17306.1080307@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.