From: Arjan van de Ven <arjan@linux.intel.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH] x86, kernel: make dump_pagetables a tristate
Date: Mon, 01 Jul 2013 06:58:46 -0700 [thread overview]
Message-ID: <51D18B16.1000402@linux.intel.com> (raw)
In-Reply-To: <20130630040514.GA20587@www.outflux.net>
On 6/29/2013 9:05 PM, Kees Cook wrote:
> Being able to examine page tables is handy, so make this a module that
> can be loaded as needed.
I personally don't think this is a good idea due to the various
security/etc implications of this feature... should really just
be off for non-debug kernels, not "off unless you load the module"
> +#ifdef CONFIG_X86_64
> +EXPORT_SYMBOL_GPL(init_level4_pgt);
> +#else
> +EXPORT_SYMBOL_GPL(swapper_pg_dir);
> +#endif
like these really have no business in any module
next prev parent reply other threads:[~2013-07-01 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 4:05 [PATCH] x86, kernel: make dump_pagetables a tristate Kees Cook
2013-07-01 13:58 ` Arjan van de Ven [this message]
2013-07-01 15:55 ` Kees Cook
2013-07-01 16:35 ` Arjan van de Ven
2013-07-01 16:56 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D18B16.1000402@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.