From: Richard Henderson <rth@twiddle.net>
To: Petar Jovanovic <petar.jovanovic@rt-rk.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, petar.jovanovic@imgtec.com
Subject: Re: [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round
Date: Mon, 01 Jul 2013 07:52:18 -0700 [thread overview]
Message-ID: <51D197A2.4050706@twiddle.net> (raw)
In-Reply-To: <1372636487-124064-1-git-send-email-petar.jovanovic@rt-rk.com>
On 06/30/2013 04:54 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> This change corrects rounding and saturation of Q31 fractional value in
> mipsdsp_trunc16_sat16_round(). Overflow detection was incorrect for the
> corner case for PRECRQ_RS.PH, and this test case is also part of the change.
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
>
> v2:
>
> - added comments to the code
>
> target-mips/dsp_helper.c | 16 +++++++++++-----
> tests/tcg/mips/mips32-dsp/precrq_rs_ph_w.c | 24 ++++++++++++++++++++----
> 2 files changed, 31 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2013-07-01 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 23:54 [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round Petar Jovanovic
2013-07-01 14:52 ` Richard Henderson [this message]
2013-07-08 9:14 ` Petar Jovanovic
2013-07-15 11:46 ` Petar Jovanovic
2013-07-22 8:51 ` Petar Jovanovic
2013-07-27 23:33 ` Petar Jovanovic
2013-07-28 22:28 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D197A2.4050706@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=petar.jovanovic@imgtec.com \
--cc=petar.jovanovic@rt-rk.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.