From: Steve Dickson <SteveD@redhat.com>
To: Weston Andros Adamson <dros@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsiostat: restore output format
Date: Mon, 01 Jul 2013 12:03:57 -0400 [thread overview]
Message-ID: <51D1A86D.7050904@RedHat.com> (raw)
In-Reply-To: <1371653913-1697-1-git-send-email-dros@netapp.com>
On 19/06/13 10:58, Weston Andros Adamson wrote:
> recent changes to support python 3 changed the output of nfsiostat from:
>
> read: ops/s kB/s kB/op retrans avg RTT (ms) avg exe (ms)
> 48.094 2889.133 60.072 0 (0.0%) 177.160 184.833
> ...
>
> to:
>
> read:
> ops/s kB/s kB/op retrans avg RTT (ms) avg exe (ms)
> 0.000
> 0.000
> 0.000
> 0 (0.0%)
> 0.000
> 0.000
> ...
>
> Signed-off-by: Weston Andros Adamson <dros@netapp.com>
Committed!
steved.
> ---
> tools/nfs-iostat/nfs-iostat.py | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/nfs-iostat/nfs-iostat.py b/tools/nfs-iostat/nfs-iostat.py
> index dfbef87..c035537 100644
> --- a/tools/nfs-iostat/nfs-iostat.py
> +++ b/tools/nfs-iostat/nfs-iostat.py
> @@ -353,14 +353,14 @@ class DeviceData:
> exe_per_op = 0.0
>
> op += ':'
> - print('%s' % op.lower().ljust(15))
> + print('%s' % op.lower().ljust(15), end='')
> print(' ops/s\t\t kB/s\t\t kB/op\t\tretrans\t\tavg RTT (ms)\tavg exe (ms)')
>
> - print('\t\t%7.3f' % (ops / sample_time))
> - print('\t%7.3f' % (kilobytes / sample_time))
> - print('\t%7.3f' % kb_per_op)
> - print(' %7d (%3.1f%%)' % (retrans, retrans_percent))
> - print('\t%7.3f' % rtt_per_op)
> + print('\t\t%7.3f' % (ops / sample_time), end='')
> + print('\t%7.3f' % (kilobytes / sample_time), end='')
> + print('\t%7.3f' % kb_per_op, end='')
> + print(' %7d (%3.1f%%)' % (retrans, retrans_percent), end='')
> + print('\t%7.3f' % rtt_per_op, end='')
> print('\t%7.3f' % exe_per_op)
>
> def ops(self, sample_time):
> @@ -392,7 +392,7 @@ class DeviceData:
> print()
>
> print(' op/s\t\trpc bklog')
> - print('%7.2f' % (sends / sample_time))
> + print('%7.2f' % (sends / sample_time), end='')
> print('\t%7.2f' % backlog)
>
> if which == 0:
>
prev parent reply other threads:[~2013-07-01 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 14:58 [PATCH] nfsiostat: restore output format Weston Andros Adamson
2013-07-01 16:03 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D1A86D.7050904@RedHat.com \
--to=steved@redhat.com \
--cc=dros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.