From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36111)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtiGU-0000sz-Qa
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:51:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtiGS-0004cy-94
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:51:50 -0400
Received: from cantor2.suse.de ([195.135.220.15]:40873 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtiGS-0004cZ-2U
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:51:48 -0400
Message-ID: <51D1C1AF.7080300@suse.de>
Date: Mon, 01 Jul 2013 19:51:43 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1372536117-28167-1-git-send-email-afaerber@suse.de>
	<1372536117-28167-24-git-send-email-afaerber@suse.de>
	<51D1B98A.2010908@twiddle.net>
In-Reply-To: <51D1B98A.2010908@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 23/41] target-xtensa: Change
 gen_intermediate_code_internal() arg to XtensaCPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Mike Frysinger <vapier@gentoo.org>, Max Filippov <jcmvbkbc@gmail.com>, jan.kiszka@web.de, qemu-devel@nongnu.org

Am 01.07.2013 19:16, schrieb Richard Henderson:
> On 06/29/2013 01:01 PM, Andreas F=C3=A4rber wrote:
>> Also use bool type while at it.
>>
>> Prepares for moving singlestep_enabled field to CPUState.
>>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>> ---
>>  target-xtensa/translate.c | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)
>=20
> All of 10-23/41,
>=20
> Reviewed-by: Richard Henderson <rth@twiddle.net>

I wonder, all targets seem to implement the same pattern of passing a
hard-coded bool argument to their internal function.

Is there any reason not to have translate-all.c call the function with
that true/false directly?

That would then call for using CPUState *cs argument and leaving FooCPU
*cpu as local variable only where needed. In that case it would be a
central change covering all targets in one patch. :)

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg