From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52820)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Utiv2-0001NP-5F
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:33:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Utiur-0005CT-RN
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:33:44 -0400
Received: from goliath.siemens.de ([192.35.17.28]:26301)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Utiur-0005CL-GN
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:33:33 -0400
Message-ID: <51D1CB7B.4060005@siemens.com>
Date: Mon, 01 Jul 2013 20:33:31 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1372438702-20491-1-git-send-email-pbonzini@redhat.com>
	<1372438702-20491-8-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1372438702-20491-8-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in
	qemu_ram_addr_from_host
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2013-06-28 18:58, Paolo Bonzini wrote:
> This function is not used outside the iothread mutex, so it
> can use ram_list.mru_block.

Add a comment to qemu_ram_addr_from_host to document this requirement?

> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  exec.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index 8722420..f3d7b18 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1408,18 +1408,26 @@ int qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr)
>          return 0;
>      }
>  
> +    block = ram_list.mru_block;
> +    if (block && block->host && host - block->host < block->length) {
> +        goto found;
> +    }
> +
>      QTAILQ_FOREACH(block, &ram_list.blocks, next) {
>          /* This case append when the block is not mapped. */
>          if (block->host == NULL) {
>              continue;
>          }
>          if (host - block->host < block->length) {
> -            *ram_addr = block->offset + (host - block->host);
> -            return 0;
> +            goto found;
>          }
>      }
>  
>      return -1;
> +
> +found:
> +    *ram_addr = block->offset + (host - block->host);
> +    return 0;
>  }
>  
>  /* Some of the softmmu routines need to translate from a host pointer
> 

Beside the nit:
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux