From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [alsa-devel] [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting Date: Mon, 01 Jul 2013 21:23:22 +0200 Message-ID: <51D1D72A.4090004@free-electrons.com> References: <1372666571-17276-1-git-send-email-shawn.guo@linaro.org> <1372666571-17276-2-git-send-email-shawn.guo@linaro.org> <20130701100710.GB27646@sirena.org.uk> <201307011254.18952.marex@denx.de> <20130701142610.GR13206@S2101-09.ap.freescale.net> <20130701143415.GA14172@S2101-09.ap.freescale.net> <20130701153327.GX13206@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fabio Estevam Cc: Marek Vasut , Fabio Estevam , alsa-devel@alsa-project.org, Mark Brown , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On 01/07/2013 17:42, Fabio Estevam wrote: > On Mon, Jul 1, 2013 at 12:33 PM, Shawn Guo wrote: >> On Mon, Jul 01, 2013 at 12:11:58PM -0300, Fabio Estevam wrote: >>> On Mon, Jul 1, 2013 at 11:34 AM, Shawn Guo wrote: >>> >>>> And also why we do not see the impact of i2c issue on sgtl5000 before >>>> the offending commit af8ee11 (ASoC: sgtl5000: Fix driver probe after >>>> reset)? >>> >>> Probably because the mxs i2c was working before this commit. >> >> Do you have a commit id at which mxs i2c is known good? I would like to >> find out it's a mxs i2c issue or sgtl5000 problem. > > I don't have it, but I am adding Alexandre in case he knows. > > Alexandre, > > Do you happen to know a commit id which does not show the mxs i2c > timeouts you have been observing? > the closest I have is that 3.7 was ok but 3.9 is broken. In the meant time, Marek did rewrite the whole stuff ;) >> >>> >>> Commit af8ee11 does fix the reset probe on mx51/mx53/mx6. >>> >>> It's only on mx28 that we have this issue. >>> >>> Also, please see this patch from Alexandre Belloni: >>> https://lkml.org/lkml/2013/6/24/430 >>> >>> He can only connect the ADC chip if he uses I2C bitbang mode on mx28. >> >> Does I2C bitbang mode help fix the sgtl5000 issue here? > > I haven't made this test. > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Mon, 01 Jul 2013 21:23:22 +0200 Subject: [alsa-devel] [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting In-Reply-To: References: <1372666571-17276-1-git-send-email-shawn.guo@linaro.org> <1372666571-17276-2-git-send-email-shawn.guo@linaro.org> <20130701100710.GB27646@sirena.org.uk> <201307011254.18952.marex@denx.de> <20130701142610.GR13206@S2101-09.ap.freescale.net> <20130701143415.GA14172@S2101-09.ap.freescale.net> <20130701153327.GX13206@S2101-09.ap.freescale.net> Message-ID: <51D1D72A.4090004@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/07/2013 17:42, Fabio Estevam wrote: > On Mon, Jul 1, 2013 at 12:33 PM, Shawn Guo wrote: >> On Mon, Jul 01, 2013 at 12:11:58PM -0300, Fabio Estevam wrote: >>> On Mon, Jul 1, 2013 at 11:34 AM, Shawn Guo wrote: >>> >>>> And also why we do not see the impact of i2c issue on sgtl5000 before >>>> the offending commit af8ee11 (ASoC: sgtl5000: Fix driver probe after >>>> reset)? >>> >>> Probably because the mxs i2c was working before this commit. >> >> Do you have a commit id at which mxs i2c is known good? I would like to >> find out it's a mxs i2c issue or sgtl5000 problem. > > I don't have it, but I am adding Alexandre in case he knows. > > Alexandre, > > Do you happen to know a commit id which does not show the mxs i2c > timeouts you have been observing? > the closest I have is that 3.7 was ok but 3.9 is broken. In the meant time, Marek did rewrite the whole stuff ;) >> >>> >>> Commit af8ee11 does fix the reset probe on mx51/mx53/mx6. >>> >>> It's only on mx28 that we have this issue. >>> >>> Also, please see this patch from Alexandre Belloni: >>> https://lkml.org/lkml/2013/6/24/430 >>> >>> He can only connect the ADC chip if he uses I2C bitbang mode on mx28. >> >> Does I2C bitbang mode help fix the sgtl5000 issue here? > > I haven't made this test. > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com