From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [alsa-devel] [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting Date: Mon, 01 Jul 2013 21:28:26 +0200 Message-ID: <51D1D85A.8060807@free-electrons.com> References: <1372666571-17276-1-git-send-email-shawn.guo@linaro.org> <20130701153327.GX13206@S2101-09.ap.freescale.net> <201307011943.27489.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fabio Estevam Cc: Marek Vasut , Fabio Estevam , alsa-devel@alsa-project.org, Mark Brown , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org Hi, On 01/07/2013 21:14, Fabio Estevam wrote: > Hi Marek, > > On Mon, Jul 1, 2013 at 2:43 PM, Marek Vasut wrote: > >> I think you can just disable the PIO mode altogether (around line 500 ... if >> (msg->len < 8) ... replace this with if (0) ) and then the problem should not be >> there (if it's a PIO problem). > > Yes, this is a good suggestion. > > This is what I did on 3.10 kernel: > > - Booted a 3.10 kernel, audio is probed correctly > > - Enabled touchscreen: > It definitely seems to be an issue with PIO mode as the investigation from Torsten Fleischer showed. I'll test that on my boards tonight. I'll also try to remove the touchscreen support to see if I observe the same thing as you do. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Mon, 01 Jul 2013 21:28:26 +0200 Subject: [alsa-devel] [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting In-Reply-To: References: <1372666571-17276-1-git-send-email-shawn.guo@linaro.org> <20130701153327.GX13206@S2101-09.ap.freescale.net> <201307011943.27489.marex@denx.de> Message-ID: <51D1D85A.8060807@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 01/07/2013 21:14, Fabio Estevam wrote: > Hi Marek, > > On Mon, Jul 1, 2013 at 2:43 PM, Marek Vasut wrote: > >> I think you can just disable the PIO mode altogether (around line 500 ... if >> (msg->len < 8) ... replace this with if (0) ) and then the problem should not be >> there (if it's a PIO problem). > > Yes, this is a good suggestion. > > This is what I did on 3.10 kernel: > > - Booted a 3.10 kernel, audio is probed correctly > > - Enabled touchscreen: > It definitely seems to be an issue with PIO mode as the investigation from Torsten Fleischer showed. I'll test that on my boards tonight. I'll also try to remove the touchscreen support to see if I observe the same thing as you do. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com