From mboxrd@z Thu Jan 1 00:00:00 1970 From: voice.shen@atmel.com (Bo Shen) Date: Tue, 2 Jul 2013 11:01:45 +0800 Subject: [RFC PATCH 01/13] misc: atmel_ssc: add device tree DMA support In-Reply-To: <1372667978-4718-2-git-send-email-richard.genoud@gmail.com> References: <1372667978-4718-1-git-send-email-richard.genoud@gmail.com> <1372667978-4718-2-git-send-email-richard.genoud@gmail.com> Message-ID: <51D24299.9050209@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Richard, On 7/1/2013 16:39, Richard Genoud wrote: > The ssc device has to fill the at_dma_slave structure with the > device tree informations. > Doing a of_dma_request_slave_channel()+dma_release_channel() for that > seems wrong (or at least not very clean). Please hold on of this, as to the ASoC dmaengine will deal with this. So, we not need do it manually. Now, I am working on it. And will send out the patch soon after testing OK. > Signed-off-by: Richard Genoud > --- > drivers/misc/atmel-ssc.c | 56 +++++++++++++++++++++++++++++++ > include/linux/atmel-ssc.h | 2 ++ > include/linux/platform_data/dma-atmel.h | 2 ++ > 3 files changed, 60 insertions(+) Best Regards, Bo Shen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Subject: Re: [RFC PATCH 01/13] misc: atmel_ssc: add device tree DMA support Date: Tue, 2 Jul 2013 11:01:45 +0800 Message-ID: <51D24299.9050209@atmel.com> References: <1372667978-4718-1-git-send-email-richard.genoud@gmail.com> <1372667978-4718-2-git-send-email-richard.genoud@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1372667978-4718-2-git-send-email-richard.genoud@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Richard Genoud Cc: devicetree-discuss@lists.ozlabs.org, Nicolas Ferre , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?ISO-8859-1?Q?Uwe_Kleine-K=F6nig?= List-Id: devicetree@vger.kernel.org Hi Richard, On 7/1/2013 16:39, Richard Genoud wrote: > The ssc device has to fill the at_dma_slave structure with the > device tree informations. > Doing a of_dma_request_slave_channel()+dma_release_channel() for that > seems wrong (or at least not very clean). Please hold on of this, as to the ASoC dmaengine will deal with this. So, we not need do it manually. Now, I am working on it. And will send out the patch soon after testing OK. > Signed-off-by: Richard Genoud > --- > drivers/misc/atmel-ssc.c | 56 +++++++++++++++++++++++++++++++ > include/linux/atmel-ssc.h | 2 ++ > include/linux/platform_data/dma-atmel.h | 2 ++ > 3 files changed, 60 insertions(+) Best Regards, Bo Shen