From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gao feng <gaofeng@cn.fujitsu.com>
Subject: Re: [PATCH net] ipv6: ip6_append_data_mtu did not care about pmtudisc
 and frag_size
Date: Tue, 02 Jul 2013 13:42:24 +0800
Message-ID: <51D26840.9070603@cn.fujitsu.com>
References: <20130701181742.GB8937@order.stressinduktion.org> <51D23F0E.3030104@cn.fujitsu.com> <20130702051321.GB9877@order.stressinduktion.org> <20130702051841.GC9877@order.stressinduktion.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: "yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:22641 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1750887Ab3GBFk4 (ORCPT <rfc822;netdev@vger.kernel.org>);
	Tue, 2 Jul 2013 01:40:56 -0400
In-Reply-To: <20130702051841.GC9877@order.stressinduktion.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 07/02/2013 01:18 PM, Hannes Frederic Sowa wrote:
> On Tue, Jul 02, 2013 at 07:13:21AM +0200, Hannes Frederic Sowa wrote:
>> On Tue, Jul 02, 2013 at 10:46:38AM +0800, Gao feng wrote:
>>> On 07/02/2013 02:17 AM, Hannes Frederic Sowa wrote:
>>> No need to pass ipv6_pinfo to ip6_append_data_mtu, the below is enough.
>>>
>>> *mtu = min(*mtu, (np->pmtudisc == IPV6_PMTUDISC_DO) ?
>>> 				rt->dst.dev->mtu :
>>> 				dst_mtu(rt->dst.path);
>>>
>>> This patch looks good go me.
>>>
>>> Acked-by: Gao feng <gaofeng@cn.fujitsu.com>
>>>
>>> Thanks!
>>
>> Thanks for your feedback, I will incooperate it in my next version of
>> the patch. Actually, I seem to have done an error in the above code,
>> i need to replace IPV6_PMTUDISC_DO with IPV6_PMTUDISC_WANT. Does your
>> Acked-by still hold?
> 
> Erk, err, IPV6_PMTUDISC_PROBE was what i meant.
> 
> 
Yes, IPV6_PMTUDISC_PROBE is more reasonable. you can hold my ack.