From: DuanZhenzhong <zhenzhong.duan@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Anthony.Perard@citrix.com, Feng Jin <joe.jin@oracle.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] qemu-xen: free all the pirqs for msi/msix when driver unload
Date: Tue, 02 Jul 2013 13:54:57 +0800 [thread overview]
Message-ID: <51D26B31.8010409@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1307011253430.4525@kaball.uk.xensource.com>
Stefano Stabellini wrote:
> On Mon, 1 Jul 2013, Zhenzhong Duan wrote:
>
>> Pirqs are not freed when driver unload, then new pirqs are allocated when
>> driver reload. This could exhaust pirqs if do it in a loop.
>>
>> This patch fixes the bug by freeing pirqs when ENABLE bit is cleared in
>> msi/msix control reg.
>>
>> There is also other way of fixing it such as reuse pirqs between driver reload,
>> but this way is better.
>> Xen-devel: http://marc.info/?l=xen-devel&m=136800120304275&w=2
>>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>>
>
> It looks OK to me, I'll have to trust you to have tested this patch
> properly too.
>
Not yet, it just passed build test.
Pls hold off until I got permit to override the 4.1.30-OVM test env with
upstream things and test.
Or is there some way of testing with 4.1.30-OVM + qemu-system-i386 ?
zduan
next prev parent reply other threads:[~2013-07-02 5:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 5:46 [PATCH] qemu-xen: free all the pirqs for msi/msix when driver unload Zhenzhong Duan
2013-07-01 11:54 ` Stefano Stabellini
2013-07-02 5:54 ` DuanZhenzhong [this message]
2013-07-02 10:25 ` Stefano Stabellini
-- strict thread matches above, loose matches on Subject: below --
2014-04-08 16:37 [PATCH] Fix qemu-xen with PCI passthrough konrad
2014-04-08 16:37 ` [PATCH] qemu-xen: free all the pirqs for msi/msix when driver unload konrad
2014-04-08 17:22 ` Stefano Stabellini
2014-04-08 17:29 ` Konrad Rzeszutek Wilk
2014-04-08 17:38 ` Stefano Stabellini
2014-04-30 13:30 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D26B31.8010409@oracle.com \
--to=zhenzhong.duan@oracle.com \
--cc=Anthony.Perard@citrix.com \
--cc=joe.jin@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.