All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: Symlink lib32 to lib for MIPS64/n32
Date: Tue, 02 Jul 2013 07:59:45 +0200	[thread overview]
Message-ID: <51D26C51.8070108@mind.be> (raw)
In-Reply-To: <1372675884-963-1-git-send-email-markos.chandras@gmail.com>

On 07/01/13 12:51, Markos Chandras wrote:
> From: Markos Chandras <markos.chandras@imgtec.com>
>
> gcc hardcodes the uClibc interpreter for MIPS64/n32 as follows:
> (gcc-4.7.3, gcc/config/mips/linux64.h):
> define UCLIBC_DYNAMIC_LINKERN32 "/lib32/ld-uClibc.so.0"
>
> However, buildroot always creates the $(TARGET_DIR)/lib and
> $(TARGET_DIR)/usr/lib directories, therefore for consinstency
> reasons, we create a lib32->lib symlink to fix the interpreter
> problems for MIPS64/n32.

  I would say we do it for all 32-bit platforms. If people feel they 
can't afford the overhead of two additional inodes in their rootfs, they 
can still remove the link in a post-build script.

>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
>   Makefile | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index c514e4f..0059d0c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -436,6 +436,12 @@ $(BUILD_DIR)/.root:
>   		--exclude .hg --exclude=CVS --exclude '*~' \
>   		$(TARGET_SKELETON)/ $(TARGET_DIR)/
>   	cp support/misc/target-dir-warning.txt $(TARGET_DIR_WARNING_FILE)
> +ifeq ($(BR2_MIPS_NABI32),y)
> +	pushd $(TARGET_DIR) > /dev/null 2>&1; \
> +		ln -sfn lib lib32; \
> +		ln -sfn lib usr/lib32; \

  No need for the pushd/popd; just:

	ln -sfn lib $(TARGET_DIR)/lib32
	ln -sfn lib $(TARGET_DIR)/usr/lib32


  Regards,
  Arnout

> +		popd > /dev/null 2>&1
> +endif
>   	touch $@
>
>   $(TARGET_DIR): $(BUILD_DIR)/.root
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-07-02  5:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01 10:51 [Buildroot] [PATCH] Makefile: Symlink lib32 to lib for MIPS64/n32 Markos Chandras
2013-07-02  5:59 ` Arnout Vandecappelle [this message]
2013-07-02 11:04   ` Markos Chandras
2013-07-02 13:36   ` Markos Chandras
2013-07-02 16:29     ` Arnout Vandecappelle
2013-07-02 17:55       ` Markos Chandras
2013-07-02 18:12         ` Arnout Vandecappelle
2013-07-02 18:19           ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D26C51.8070108@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.