From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events Date: Tue, 2 Jul 2013 11:39:28 +0530 Message-ID: <51D26E98.9040303@ti.com> References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-4-git-send-email-gururaja.hebbar@ti.com> <51D26CFA.5090500@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EC4E7AB-yXqyApvAXouIQmiDNMet8wC/G2K4zDHf@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org To: "Hebbar, Gururaja" Cc: Alessandro Zummo , "davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org" , "Cousson, Benoit" , "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Rob Landley , Grant Likely , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-omap@vger.kernel.org T24gNy8yLzIwMTMgMTE6MzQgQU0sIEhlYmJhciwgR3VydXJhamEgd3JvdGU6Cj4gT24gVHVlLCBK dWwgMDIsIDIwMTMgYXQgMTE6MzI6MzQsIE5vcmksIFNla2hhciB3cm90ZToKPj4gT24gNi8yOC8y MDEzIDM6MDUgUE0sIEhlYmJhciBHdXJ1cmFqYSB3cm90ZToKPj4+IE9uIHNvbWUgcGxhdGZvcm1z IChsaWtlIEFNMzN4eCksIGEgc3BlY2lhbCByZWdpc3RlciAoUlRDX0lSUVdBS0VFTikKPj4+IGlz IGF2YWlsYWJsZSB0byBlbmFibGUgQWxhcm0gV2FrZXVwIGZlYXR1cmUuIFRoaXMgcmVnaXN0ZXIg bmVlZHMgdG8gYmUKPj4+IHByb3Blcmx5IGhhbmRsZWQgZm9yIHRoZSBydGN3YWtlIHRvIHdvcmsg cHJvcGVybHkuCj4+Pgo+Pj4gUGxhdGZvcm1zIHVzaW5nIHN1Y2ggSVAgc2hvdWxkIHNldCAidGks YW0zMzUyLXJ0YyIgaW4gcnRjIGRldmljZSBkdAo+Pj4gY29tcGF0aWJpbGl0eSBub2RlLgo+Pj4K Pj4+IFNpZ25lZC1vZmYtYnk6IEhlYmJhciBHdXJ1cmFqYSA8Z3VydXJhamEuaGViYmFyQHRpLmNv bT4KPj4+IENjOiBHcmFudCBMaWtlbHkgPGdyYW50Lmxpa2VseUBsaW5hcm8ub3JnPgo+Pj4gQ2M6 IFJvYiBIZXJyaW5nIDxyb2IuaGVycmluZ0BjYWx4ZWRhLmNvbT4KPj4+IENjOiBSb2IgTGFuZGxl eSA8cm9iQGxhbmRsZXkubmV0Pgo+Pj4gQ2M6IFNla2hhciBOb3JpIDxuc2VraGFyQHRpLmNvbT4K Pj4+IENjOiBLZXZpbiBIaWxtYW4gPGtoaWxtYW5AbGluYXJvLm9yZz4KPj4+IENjOiBBbGVzc2Fu ZHJvIFp1bW1vIDxhLnp1bW1vQHRvd2VydGVjaC5pdD4KPj4+IENjOiBydGMtbGludXhAZ29vZ2xl Z3JvdXBzLmNvbQo+Pj4gQ2M6IGRldmljZXRyZWUtZGlzY3Vzc0BsaXN0cy5vemxhYnMub3JnCj4+ PiBDYzogbGludXgtZG9jQHZnZXIua2VybmVsLm9yZwo+Pj4gLS0tCj4+Cj4+IFsuLi5dCj4+Cj4+ PiAtI2RlZmluZQlPTUFQX1JUQ19EQVRBX0RBODMwX0lEWAkxCj4+PiArI2RlZmluZQlPTUFQX1JU Q19EQVRBX0RBODMwX0lEWAkJMQo+Pj4gKyNkZWZpbmUJT01BUF9SVENfREFUQV9BTTMzNVhfSURY CTIKPj4+ICAKPj4+ICBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RldmljZV9pZCBvbWFwX3J0Y19k ZXZ0eXBlW10gPSB7Cj4+PiAgCXsKPj4+IEBAIC0zMDksNiArMzIxLDkgQEAgc3RhdGljIHN0cnVj dCBwbGF0Zm9ybV9kZXZpY2VfaWQgb21hcF9ydGNfZGV2dHlwZVtdID0gewo+Pj4gIAl9LCB7Cj4+ PiAgCQkubmFtZQk9ICJkYTgzMC1ydGMiLAo+Pj4gIAkJLmRyaXZlcl9kYXRhID0gT01BUF9SVENf SEFTX0tJQ0tFUiwKPj4+ICsJfSwgewo+Pj4gKwkJLm5hbWUJPSAiYW0zMzV4LXJ0YyIsCj4+Cj4+ IG1heSBiZSB1c2UgYW0zMzUyLXJ0YyBoZXJlIGp1c3QgdG8ga2VlcCB0aGUgcGxhdGZvcm0gZGV2 aWNlIG5hbWUgYW5kIG9mCj4+IGNvbXBhdGlibGUgaW4gc3luYy4KPiAKPiBDb3JyZWN0LiBJIHdp bGwgdXBkYXRlIHRoZSBzYW1lIGluIHYyLgo+IAo+Pgo+Pj4gKwkJLmRyaXZlcl9kYXRhID0gT01B UF9SVENfSEFTX0tJQ0tFUiB8IE9NQVBfUlRDX0hBU19JUlFXQUtFRU4sCj4+PiAgCX0sCj4+PiAg CXt9LAo+Pgo+PiBJdCBpcyBiZXR0ZXIgdG8gdXNlIHRoZSBpbmRleCBkZWZpbmVkIGFib3ZlIGlu IHRoZSBzdGF0aWMgaW5pdGlhbGl6YXRpb24KPj4gc28gdGhleSByZW1haW4gaW4gc3luYy4KPiAK PiBTb3JyeS4gSSBkaWRu4oCZdCBnZXQgdGhpcy4KPiAKClNlZSBleGFtcGxlIGJlbG93IEkgcHJv dmlkZWQuIElmIGl0cyBzdGlsbCBub3QgY2xlYXIsIGxldCBtZSBrbm93IHdoYXQKaXMgbm90IGNs ZWFyLgoKPj4gCS4uLgo+PiAJW09NQVBfUlRDX0RBVEFfREE4MzBfSURYXSA9IHsKPj4gCQkubmFt ZQk9ICJkYTgzMC1ydGMiLAo+PiAJCS5kcml2ZXJfZGF0YSA9IE9NQVBfUlRDX0hBU19LSUNLRVIs Cj4+IAl9LAoKVGhhbmtzLApTZWtoYXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KRGF2aW5jaS1saW51eC1vcGVuLXNvdXJjZSBtYWlsaW5nIGxpc3QKRGF2 aW5jaS1saW51eC1vcGVuLXNvdXJjZUBsaW51eC5kYXZpbmNpZHNwLmNvbQpodHRwOi8vbGludXgu ZGF2aW5jaWRzcC5jb20vbWFpbG1hbi9saXN0aW5mby9kYXZpbmNpLWxpbnV4LW9wZW4tc291cmNl Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Tue, 2 Jul 2013 11:39:28 +0530 Subject: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-4-git-send-email-gururaja.hebbar@ti.com> <51D26CFA.5090500@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> Message-ID: <51D26E98.9040303@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 7/2/2013 11:34 AM, Hebbar, Gururaja wrote: > On Tue, Jul 02, 2013 at 11:32:34, Nori, Sekhar wrote: >> On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: >>> On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN) >>> is available to enable Alarm Wakeup feature. This register needs to be >>> properly handled for the rtcwake to work properly. >>> >>> Platforms using such IP should set "ti,am3352-rtc" in rtc device dt >>> compatibility node. >>> >>> Signed-off-by: Hebbar Gururaja >>> Cc: Grant Likely >>> Cc: Rob Herring >>> Cc: Rob Landley >>> Cc: Sekhar Nori >>> Cc: Kevin Hilman >>> Cc: Alessandro Zummo >>> Cc: rtc-linux at googlegroups.com >>> Cc: devicetree-discuss at lists.ozlabs.org >>> Cc: linux-doc at vger.kernel.org >>> --- >> >> [...] >> >>> -#define OMAP_RTC_DATA_DA830_IDX 1 >>> +#define OMAP_RTC_DATA_DA830_IDX 1 >>> +#define OMAP_RTC_DATA_AM335X_IDX 2 >>> >>> static struct platform_device_id omap_rtc_devtype[] = { >>> { >>> @@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] = { >>> }, { >>> .name = "da830-rtc", >>> .driver_data = OMAP_RTC_HAS_KICKER, >>> + }, { >>> + .name = "am335x-rtc", >> >> may be use am3352-rtc here just to keep the platform device name and of >> compatible in sync. > > Correct. I will update the same in v2. > >> >>> + .driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN, >>> }, >>> {}, >> >> It is better to use the index defined above in the static initialization >> so they remain in sync. > > Sorry. I didn?t get this. > See example below I provided. If its still not clear, let me know what is not clear. >> ... >> [OMAP_RTC_DATA_DA830_IDX] = { >> .name = "da830-rtc", >> .driver_data = OMAP_RTC_HAS_KICKER, >> }, Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932180Ab3GBGKe (ORCPT ); Tue, 2 Jul 2013 02:10:34 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:44150 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120Ab3GBGKc (ORCPT ); Tue, 2 Jul 2013 02:10:32 -0400 Message-ID: <51D26E98.9040303@ti.com> Date: Tue, 2 Jul 2013 11:39:28 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Hebbar, Gururaja" CC: "khilman@linaro.org" , "tony@atomide.com" , "Cousson, Benoit" , "linux-omap@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "davinci-linux-open-source@linux.davincidsp.com" , "Bedia, Vaibhav" , "Rajashekhara, Sudhakar" , Grant Likely , Rob Herring , Rob Landley , Alessandro Zummo , "rtc-linux@googlegroups.com" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-4-git-send-email-gururaja.hebbar@ti.com> <51D26CFA.5090500@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/2013 11:34 AM, Hebbar, Gururaja wrote: > On Tue, Jul 02, 2013 at 11:32:34, Nori, Sekhar wrote: >> On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: >>> On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN) >>> is available to enable Alarm Wakeup feature. This register needs to be >>> properly handled for the rtcwake to work properly. >>> >>> Platforms using such IP should set "ti,am3352-rtc" in rtc device dt >>> compatibility node. >>> >>> Signed-off-by: Hebbar Gururaja >>> Cc: Grant Likely >>> Cc: Rob Herring >>> Cc: Rob Landley >>> Cc: Sekhar Nori >>> Cc: Kevin Hilman >>> Cc: Alessandro Zummo >>> Cc: rtc-linux@googlegroups.com >>> Cc: devicetree-discuss@lists.ozlabs.org >>> Cc: linux-doc@vger.kernel.org >>> --- >> >> [...] >> >>> -#define OMAP_RTC_DATA_DA830_IDX 1 >>> +#define OMAP_RTC_DATA_DA830_IDX 1 >>> +#define OMAP_RTC_DATA_AM335X_IDX 2 >>> >>> static struct platform_device_id omap_rtc_devtype[] = { >>> { >>> @@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] = { >>> }, { >>> .name = "da830-rtc", >>> .driver_data = OMAP_RTC_HAS_KICKER, >>> + }, { >>> + .name = "am335x-rtc", >> >> may be use am3352-rtc here just to keep the platform device name and of >> compatible in sync. > > Correct. I will update the same in v2. > >> >>> + .driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN, >>> }, >>> {}, >> >> It is better to use the index defined above in the static initialization >> so they remain in sync. > > Sorry. I didn’t get this. > See example below I provided. If its still not clear, let me know what is not clear. >> ... >> [OMAP_RTC_DATA_DA830_IDX] = { >> .name = "da830-rtc", >> .driver_data = OMAP_RTC_HAS_KICKER, >> }, Thanks, Sekhar