From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 4/4] ARM: dts: AM33XX: update rtc node compatibility Date: Tue, 2 Jul 2013 11:42:49 +0530 Message-ID: <51D26F61.7080308@ti.com> References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-5-git-send-email-gururaja.hebbar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1372412109-986-5-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org To: Hebbar Gururaja Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, =?UTF-8?B?QmVub8OudCBDb3Vzc29u?= , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-omap@vger.kernel.org Changing to Benoit's gmail id since he apparently wont access TI mail anymore. On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: > Since AM33xx RTC IP has RTC_IRQWAKEEN to support Alarm Wake-up. > > Update the rtc compatible property to "ti,am3352-rtc" to enable handling > of this feature inside rtc-omap driver. > > Signed-off-by: Hebbar Gururaja > Cc: Tony Lindgren > Cc: Sekhar Nori > Cc: Kevin Hilman > Cc: b-cousson-l0cyMroinI0@public.gmane.org > --- > :100644 100644 77aa1b0... dde180a... M arch/arm/boot/dts/am33xx.dtsi > arch/arm/boot/dts/am33xx.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 77aa1b0..dde180a 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -297,7 +297,7 @@ > }; > > rtc@44e3e000 { > - compatible = "ti,da830-rtc"; > + compatible = "ti,am3352-rtc"; compatible is a list so you can instead do: compatible = "ti,am3352-rtc", "ti,da830-rtc"; That way the dts works irrespective of driver updates. When driver supports enhanced features of hardware, they are available to the user else the basic functionality still works. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Tue, 2 Jul 2013 11:42:49 +0530 Subject: [PATCH 4/4] ARM: dts: AM33XX: update rtc node compatibility In-Reply-To: <1372412109-986-5-git-send-email-gururaja.hebbar@ti.com> References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-5-git-send-email-gururaja.hebbar@ti.com> Message-ID: <51D26F61.7080308@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Changing to Benoit's gmail id since he apparently wont access TI mail anymore. On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: > Since AM33xx RTC IP has RTC_IRQWAKEEN to support Alarm Wake-up. > > Update the rtc compatible property to "ti,am3352-rtc" to enable handling > of this feature inside rtc-omap driver. > > Signed-off-by: Hebbar Gururaja > Cc: Tony Lindgren > Cc: Sekhar Nori > Cc: Kevin Hilman > Cc: b-cousson at ti.com > --- > :100644 100644 77aa1b0... dde180a... M arch/arm/boot/dts/am33xx.dtsi > arch/arm/boot/dts/am33xx.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 77aa1b0..dde180a 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -297,7 +297,7 @@ > }; > > rtc at 44e3e000 { > - compatible = "ti,da830-rtc"; > + compatible = "ti,am3352-rtc"; compatible is a list so you can instead do: compatible = "ti,am3352-rtc", "ti,da830-rtc"; That way the dts works irrespective of driver updates. When driver supports enhanced features of hardware, they are available to the user else the basic functionality still works. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932232Ab3GBGNW (ORCPT ); Tue, 2 Jul 2013 02:13:22 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:47013 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932102Ab3GBGNV (ORCPT ); Tue, 2 Jul 2013 02:13:21 -0400 Message-ID: <51D26F61.7080308@ti.com> Date: Tue, 2 Jul 2013 11:42:49 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Hebbar Gururaja CC: , , =?UTF-8?B?QmVub8OudCBDb3Vzc29u?= , , , , , , , Subject: Re: [PATCH 4/4] ARM: dts: AM33XX: update rtc node compatibility References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-5-git-send-email-gururaja.hebbar@ti.com> In-Reply-To: <1372412109-986-5-git-send-email-gururaja.hebbar@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changing to Benoit's gmail id since he apparently wont access TI mail anymore. On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: > Since AM33xx RTC IP has RTC_IRQWAKEEN to support Alarm Wake-up. > > Update the rtc compatible property to "ti,am3352-rtc" to enable handling > of this feature inside rtc-omap driver. > > Signed-off-by: Hebbar Gururaja > Cc: Tony Lindgren > Cc: Sekhar Nori > Cc: Kevin Hilman > Cc: b-cousson@ti.com > --- > :100644 100644 77aa1b0... dde180a... M arch/arm/boot/dts/am33xx.dtsi > arch/arm/boot/dts/am33xx.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 77aa1b0..dde180a 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -297,7 +297,7 @@ > }; > > rtc@44e3e000 { > - compatible = "ti,da830-rtc"; > + compatible = "ti,am3352-rtc"; compatible is a list so you can instead do: compatible = "ti,am3352-rtc", "ti,da830-rtc"; That way the dts works irrespective of driver updates. When driver supports enhanced features of hardware, they are available to the user else the basic functionality still works. Thanks, Sekhar