From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events Date: Tue, 2 Jul 2013 11:46:50 +0530 Message-ID: <51D27052.6080303@ti.com> References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-4-git-send-email-gururaja.hebbar@ti.com> <51D26CFA.5090500@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> <51D26E98.9040303@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7CC@DBDE04.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EC4E7CC-yXqyApvAXouIQmiDNMet8wC/G2K4zDHf@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: "Hebbar, Gururaja" Cc: Alessandro Zummo , "davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org" , "khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Bedia, Vaibhav" , "Rajashekhara, Sudhakar" , Rob Herring , Grant Likely , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-omap@vger.kernel.org CgpPbiA3LzIvMjAxMyAxMTo0MSBBTSwgSGViYmFyLCBHdXJ1cmFqYSB3cm90ZToKPiBPbiBUdWUs IEp1bCAwMiwgMjAxMyBhdCAxMTozOToyOCwgTm9yaSwgU2VraGFyIHdyb3RlOgo+PiBPbiA3LzIv MjAxMyAxMTozNCBBTSwgSGViYmFyLCBHdXJ1cmFqYSB3cm90ZToKPj4+IE9uIFR1ZSwgSnVsIDAy LCAyMDEzIGF0IDExOjMyOjM0LCBOb3JpLCBTZWtoYXIgd3JvdGU6Cj4+Pj4gT24gNi8yOC8yMDEz IDM6MDUgUE0sIEhlYmJhciBHdXJ1cmFqYSB3cm90ZToKPj4+Pj4gT24gc29tZSBwbGF0Zm9ybXMg KGxpa2UgQU0zM3h4KSwgYSBzcGVjaWFsIHJlZ2lzdGVyIChSVENfSVJRV0FLRUVOKQo+Pj4+PiBp cyBhdmFpbGFibGUgdG8gZW5hYmxlIEFsYXJtIFdha2V1cCBmZWF0dXJlLiBUaGlzIHJlZ2lzdGVy IG5lZWRzIHRvIGJlCj4+Pj4+IHByb3Blcmx5IGhhbmRsZWQgZm9yIHRoZSBydGN3YWtlIHRvIHdv cmsgcHJvcGVybHkuCj4+Pj4+Cj4+Pj4+IFBsYXRmb3JtcyB1c2luZyBzdWNoIElQIHNob3VsZCBz ZXQgInRpLGFtMzM1Mi1ydGMiIGluIHJ0YyBkZXZpY2UgZHQKPj4+Pj4gY29tcGF0aWJpbGl0eSBu b2RlLgo+Pj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBIZWJiYXIgR3VydXJhamEgPGd1cnVyYWph LmhlYmJhckB0aS5jb20+Cj4+Pj4+IENjOiBHcmFudCBMaWtlbHkgPGdyYW50Lmxpa2VseUBsaW5h cm8ub3JnPgo+Pj4+PiBDYzogUm9iIEhlcnJpbmcgPHJvYi5oZXJyaW5nQGNhbHhlZGEuY29tPgo+ Pj4+PiBDYzogUm9iIExhbmRsZXkgPHJvYkBsYW5kbGV5Lm5ldD4KPj4+Pj4gQ2M6IFNla2hhciBO b3JpIDxuc2VraGFyQHRpLmNvbT4KPj4+Pj4gQ2M6IEtldmluIEhpbG1hbiA8a2hpbG1hbkBsaW5h cm8ub3JnPgo+Pj4+PiBDYzogQWxlc3NhbmRybyBadW1tbyA8YS56dW1tb0B0b3dlcnRlY2guaXQ+ Cj4+Pj4+IENjOiBydGMtbGludXhAZ29vZ2xlZ3JvdXBzLmNvbQo+Pj4+PiBDYzogZGV2aWNldHJl ZS1kaXNjdXNzQGxpc3RzLm96bGFicy5vcmcKPj4+Pj4gQ2M6IGxpbnV4LWRvY0B2Z2VyLmtlcm5l bC5vcmcKPj4+Pj4gLS0tCj4+Pj4KPj4+PiBbLi4uXQo+Pj4+Cj4+Pj4+IC0jZGVmaW5lCU9NQVBf UlRDX0RBVEFfREE4MzBfSURYCTEKPj4+Pj4gKyNkZWZpbmUJT01BUF9SVENfREFUQV9EQTgzMF9J RFgJCTEKPj4+Pj4gKyNkZWZpbmUJT01BUF9SVENfREFUQV9BTTMzNVhfSURYCTIKPj4+Pj4gIAo+ Pj4+PiAgc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2VfaWQgb21hcF9ydGNfZGV2dHlwZVtd ID0gewo+Pj4+PiAgCXsKPj4+Pj4gQEAgLTMwOSw2ICszMjEsOSBAQCBzdGF0aWMgc3RydWN0IHBs YXRmb3JtX2RldmljZV9pZCBvbWFwX3J0Y19kZXZ0eXBlW10gPSB7Cj4+Pj4+ICAJfSwgewo+Pj4+ PiAgCQkubmFtZQk9ICJkYTgzMC1ydGMiLAo+Pj4+PiAgCQkuZHJpdmVyX2RhdGEgPSBPTUFQX1JU Q19IQVNfS0lDS0VSLAo+Pj4+PiArCX0sIHsKPj4+Pj4gKwkJLm5hbWUJPSAiYW0zMzV4LXJ0YyIs Cj4+Pj4KPj4+PiBtYXkgYmUgdXNlIGFtMzM1Mi1ydGMgaGVyZSBqdXN0IHRvIGtlZXAgdGhlIHBs YXRmb3JtIGRldmljZSBuYW1lIGFuZCBvZgo+Pj4+IGNvbXBhdGlibGUgaW4gc3luYy4KPj4+Cj4+ PiBDb3JyZWN0LiBJIHdpbGwgdXBkYXRlIHRoZSBzYW1lIGluIHYyLgo+Pj4KPj4+Pgo+Pj4+PiAr CQkuZHJpdmVyX2RhdGEgPSBPTUFQX1JUQ19IQVNfS0lDS0VSIHwgT01BUF9SVENfSEFTX0lSUVdB S0VFTiwKPj4+Pj4gIAl9LAo+Pj4+PiAgCXt9LAo+Pj4+Cj4+Pj4gSXQgaXMgYmV0dGVyIHRvIHVz ZSB0aGUgaW5kZXggZGVmaW5lZCBhYm92ZSBpbiB0aGUgc3RhdGljIGluaXRpYWxpemF0aW9uCj4+ Pj4gc28gdGhleSByZW1haW4gaW4gc3luYy4KPj4+Cj4+PiBTb3JyeS4gSSBkaWRu4oCZdCBnZXQg dGhpcy4KPj4+Cj4+Cj4+IFNlZSBleGFtcGxlIGJlbG93IEkgcHJvdmlkZWQuIElmIGl0cyBzdGls bCBub3QgY2xlYXIsIGxldCBtZSBrbm93IHdoYXQKPj4gaXMgbm90IGNsZWFyLgo+Pgo+Pj4+IAku Li4KPj4+PiAJW09NQVBfUlRDX0RBVEFfREE4MzBfSURYXSA9IHsKPj4+PiAJCS5uYW1lCT0gImRh ODMwLXJ0YyIsCj4+Pj4gCQkuZHJpdmVyX2RhdGEgPSBPTUFQX1JUQ19IQVNfS0lDS0VSLAo+Pj4+ IAl9LAo+IAo+IFRoYW5rcyBmb3IgdGhlIGNsYXJpZmljYXRpb24uIEluIHRoaXMgY2FzZSB3aWxs IGl0IG9rIGlmIEkgdXBkYXRlIHRoZSBwcmV2aW91cwo+IG1lbWJlciBhbHNvLgoKWW91IGRvbnQg cmVhbGx5IHJlZmVyZW5jZSBbMF0gaW4gb21hcF9ydGNfb2ZfbWF0Y2hbXSBzbyBldmVuIGlmIHlv dQpsZWF2ZSBpdCBhcy1pcywgdGhhdCdzIGZpbmUgd2l0aCBtZS4gSSBhbSBtb3N0bHkgY29uY2Vy bmVkIHdpdGggdGhlCmluZGV4IGRlZmluaXRpb25zIGFuZCBpbml0aWFsaXphdGlvbiBvcmRlciBi ZWluZyBvdXQgb2Ygc3luYyBhbmQgdGhhdCdzCnJlYWxseSBub3QgYW4gaXNzdWUgd2l0aCBbMF0u CgpUaGFua3MsClNla2hhcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkZXZpY2V0cmVlLWRpc2N1c3MgbWFpbGluZyBsaXN0CmRldmljZXRyZWUtZGlzY3Vz c0BsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9kZXZp Y2V0cmVlLWRpc2N1c3MK From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Tue, 2 Jul 2013 11:46:50 +0530 Subject: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EC4E7CC@DBDE04.ent.ti.com> References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-4-git-send-email-gururaja.hebbar@ti.com> <51D26CFA.5090500@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> <51D26E98.9040303@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7CC@DBDE04.ent.ti.com> Message-ID: <51D27052.6080303@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 7/2/2013 11:41 AM, Hebbar, Gururaja wrote: > On Tue, Jul 02, 2013 at 11:39:28, Nori, Sekhar wrote: >> On 7/2/2013 11:34 AM, Hebbar, Gururaja wrote: >>> On Tue, Jul 02, 2013 at 11:32:34, Nori, Sekhar wrote: >>>> On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: >>>>> On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN) >>>>> is available to enable Alarm Wakeup feature. This register needs to be >>>>> properly handled for the rtcwake to work properly. >>>>> >>>>> Platforms using such IP should set "ti,am3352-rtc" in rtc device dt >>>>> compatibility node. >>>>> >>>>> Signed-off-by: Hebbar Gururaja >>>>> Cc: Grant Likely >>>>> Cc: Rob Herring >>>>> Cc: Rob Landley >>>>> Cc: Sekhar Nori >>>>> Cc: Kevin Hilman >>>>> Cc: Alessandro Zummo >>>>> Cc: rtc-linux at googlegroups.com >>>>> Cc: devicetree-discuss at lists.ozlabs.org >>>>> Cc: linux-doc at vger.kernel.org >>>>> --- >>>> >>>> [...] >>>> >>>>> -#define OMAP_RTC_DATA_DA830_IDX 1 >>>>> +#define OMAP_RTC_DATA_DA830_IDX 1 >>>>> +#define OMAP_RTC_DATA_AM335X_IDX 2 >>>>> >>>>> static struct platform_device_id omap_rtc_devtype[] = { >>>>> { >>>>> @@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] = { >>>>> }, { >>>>> .name = "da830-rtc", >>>>> .driver_data = OMAP_RTC_HAS_KICKER, >>>>> + }, { >>>>> + .name = "am335x-rtc", >>>> >>>> may be use am3352-rtc here just to keep the platform device name and of >>>> compatible in sync. >>> >>> Correct. I will update the same in v2. >>> >>>> >>>>> + .driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN, >>>>> }, >>>>> {}, >>>> >>>> It is better to use the index defined above in the static initialization >>>> so they remain in sync. >>> >>> Sorry. I didn?t get this. >>> >> >> See example below I provided. If its still not clear, let me know what >> is not clear. >> >>>> ... >>>> [OMAP_RTC_DATA_DA830_IDX] = { >>>> .name = "da830-rtc", >>>> .driver_data = OMAP_RTC_HAS_KICKER, >>>> }, > > Thanks for the clarification. In this case will it ok if I update the previous > member also. You dont really reference [0] in omap_rtc_of_match[] so even if you leave it as-is, that's fine with me. I am mostly concerned with the index definitions and initialization order being out of sync and that's really not an issue with [0]. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132Ab3GBGRv (ORCPT ); Tue, 2 Jul 2013 02:17:51 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:49281 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932116Ab3GBGRt (ORCPT ); Tue, 2 Jul 2013 02:17:49 -0400 Message-ID: <51D27052.6080303@ti.com> Date: Tue, 2 Jul 2013 11:46:50 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Hebbar, Gururaja" CC: "khilman@linaro.org" , "tony@atomide.com" , "Cousson, Benoit" , "linux-omap@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "davinci-linux-open-source@linux.davincidsp.com" , "Bedia, Vaibhav" , "Rajashekhara, Sudhakar" , Grant Likely , Rob Herring , Rob Landley , Alessandro Zummo , "rtc-linux@googlegroups.com" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-4-git-send-email-gururaja.hebbar@ti.com> <51D26CFA.5090500@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> <51D26E98.9040303@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7CC@DBDE04.ent.ti.com> In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EC4E7CC@DBDE04.ent.ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/2013 11:41 AM, Hebbar, Gururaja wrote: > On Tue, Jul 02, 2013 at 11:39:28, Nori, Sekhar wrote: >> On 7/2/2013 11:34 AM, Hebbar, Gururaja wrote: >>> On Tue, Jul 02, 2013 at 11:32:34, Nori, Sekhar wrote: >>>> On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: >>>>> On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN) >>>>> is available to enable Alarm Wakeup feature. This register needs to be >>>>> properly handled for the rtcwake to work properly. >>>>> >>>>> Platforms using such IP should set "ti,am3352-rtc" in rtc device dt >>>>> compatibility node. >>>>> >>>>> Signed-off-by: Hebbar Gururaja >>>>> Cc: Grant Likely >>>>> Cc: Rob Herring >>>>> Cc: Rob Landley >>>>> Cc: Sekhar Nori >>>>> Cc: Kevin Hilman >>>>> Cc: Alessandro Zummo >>>>> Cc: rtc-linux@googlegroups.com >>>>> Cc: devicetree-discuss@lists.ozlabs.org >>>>> Cc: linux-doc@vger.kernel.org >>>>> --- >>>> >>>> [...] >>>> >>>>> -#define OMAP_RTC_DATA_DA830_IDX 1 >>>>> +#define OMAP_RTC_DATA_DA830_IDX 1 >>>>> +#define OMAP_RTC_DATA_AM335X_IDX 2 >>>>> >>>>> static struct platform_device_id omap_rtc_devtype[] = { >>>>> { >>>>> @@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] = { >>>>> }, { >>>>> .name = "da830-rtc", >>>>> .driver_data = OMAP_RTC_HAS_KICKER, >>>>> + }, { >>>>> + .name = "am335x-rtc", >>>> >>>> may be use am3352-rtc here just to keep the platform device name and of >>>> compatible in sync. >>> >>> Correct. I will update the same in v2. >>> >>>> >>>>> + .driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN, >>>>> }, >>>>> {}, >>>> >>>> It is better to use the index defined above in the static initialization >>>> so they remain in sync. >>> >>> Sorry. I didn’t get this. >>> >> >> See example below I provided. If its still not clear, let me know what >> is not clear. >> >>>> ... >>>> [OMAP_RTC_DATA_DA830_IDX] = { >>>> .name = "da830-rtc", >>>> .driver_data = OMAP_RTC_HAS_KICKER, >>>> }, > > Thanks for the clarification. In this case will it ok if I update the previous > member also. You dont really reference [0] in omap_rtc_of_match[] so even if you leave it as-is, that's fine with me. I am mostly concerned with the index definitions and initialization order being out of sync and that's really not an issue with [0]. Thanks, Sekhar