From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utuhd-0004Bv-Nq for qemu-devel@nongnu.org; Tue, 02 Jul 2013 03:08:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Utuhc-0005T2-Qe for qemu-devel@nongnu.org; Tue, 02 Jul 2013 03:08:41 -0400 Received: from david.siemens.de ([192.35.17.14]:25540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utuhc-0005So-HS for qemu-devel@nongnu.org; Tue, 02 Jul 2013 03:08:40 -0400 Message-ID: <51D27C73.8000500@siemens.com> Date: Tue, 02 Jul 2013 09:08:35 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1372438702-20491-1-git-send-email-pbonzini@redhat.com> <1372438702-20491-11-git-send-email-pbonzini@redhat.com> <51D1CBC4.70903@siemens.com> <51D1EA22.2020609@redhat.com> In-Reply-To: <51D1EA22.2020609@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 10/11] exec: reorganize address_space_map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "peter.maydell@linaro.org" , "qemu-devel@nongnu.org" On 2013-07-01 22:44, Paolo Bonzini wrote: > Il 01/07/2013 20:34, Jan Kiszka ha scritto: >> The transformation looks correct, but I'm currently not understanding in >> which cases we still need the loop. address_space_translate should >> return as much of the target mr as the region can contiguously provide, no? > > You could have separate sections if, for example, two consecutive ranges > map to contiguous sections but one is read-only and one is read-write. OK, makes sense. You can add my Reviewed-by: Jan Kiszka Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux