From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtuiI-0004rT-45 for qemu-devel@nongnu.org; Tue, 02 Jul 2013 03:09:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtuiH-0005Zm-8O for qemu-devel@nongnu.org; Tue, 02 Jul 2013 03:09:22 -0400 Received: from goliath.siemens.de ([192.35.17.28]:30197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtuiG-0005Zc-Ms for qemu-devel@nongnu.org; Tue, 02 Jul 2013 03:09:21 -0400 Message-ID: <51D27C9D.8090909@siemens.com> Date: Tue, 02 Jul 2013 09:09:17 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1372438702-20491-1-git-send-email-pbonzini@redhat.com> <1372438702-20491-8-git-send-email-pbonzini@redhat.com> <51D1CB7B.4060005@siemens.com> <51D1EB25.2010109@redhat.com> In-Reply-To: <51D1EB25.2010109@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "peter.maydell@linaro.org" , "qemu-devel@nongnu.org" On 2013-07-01 22:48, Paolo Bonzini wrote: > Il 01/07/2013 20:33, Jan Kiszka ha scritto: >>> This function is not used outside the iothread mutex, so it >>> can use ram_list.mru_block. >> >> Add a comment to qemu_ram_addr_from_host to document this requirement? > > Right now there is hardly any documentation of what does _not_ require > the iothread mutex... basically everything except qemu_safe_ram_ptr and > qemu_ram_ptr_length requires it. I don't disagree regarding the current state. But that doesn't imply it has to be preserved. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux