From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utx0w-0000kC-Jo for qemu-devel@nongnu.org; Tue, 02 Jul 2013 05:36:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Utx0u-0007dy-KF for qemu-devel@nongnu.org; Tue, 02 Jul 2013 05:36:46 -0400 Received: from goliath.siemens.de ([192.35.17.28]:19045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utx0u-0007dn-8I for qemu-devel@nongnu.org; Tue, 02 Jul 2013 05:36:44 -0400 Message-ID: <51D29F27.9040706@siemens.com> Date: Tue, 02 Jul 2013 11:36:39 +0200 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Liu Ping Fan , qemu-devel Objects can soon be referenced/dereference outside the BQL. So we need to use atomics in object_ref/unref. Based on patch by Liu Ping Fan. Signed-off-by: Jan Kiszka --- qom/object.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index 803b94b..a76a30b 100644 --- a/qom/object.c +++ b/qom/object.c @@ -683,16 +683,15 @@ GSList *object_class_get_list(const char *implements_type, void object_ref(Object *obj) { - obj->ref++; + __sync_fetch_and_add(&obj->ref, 1); } void object_unref(Object *obj) { g_assert(obj->ref > 0); - obj->ref--; /* parent always holds a reference to its children */ - if (obj->ref == 0) { + if (__sync_sub_and_fetch(&obj->ref, 1) == 0) { object_finalize(obj); } } -- 1.7.3.4