From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls
Date: Tue, 02 Jul 2013 11:57:17 +0200 [thread overview]
Message-ID: <51D2A3FD.3090702@redhat.com> (raw)
In-Reply-To: <51D29E0F.5000208@siemens.com>
Il 02/07/2013 11:31, Jan Kiszka ha scritto:
> On 2013-07-02 11:28, Paolo Bonzini wrote:
>> Il 02/07/2013 10:36, Jan Kiszka ha scritto:
>>>>>>> Hmm, two solutions for one problem - can we improve this in the next round?
>>>>>
>>>>> Sure, I can adapt the hw/acpi/piix4.c to use ifs in the same style as
>>>>> hw/isa/lpc_ich9.c (I find the code easier to read).
>>> I was more referring to memory_region_present vs. open-coding.
>>
>> Understood, but once you replace ?: with "if", the memory_region_present
>> wrapper loses most of the appeal. So I actually prefer the open-coded one.
>
> Well, count the memory_region_unref calls.
Fair enough... I'll move memory_region_present to memory.h/c.
Paolo
next prev parent reply other threads:[~2013-07-02 9:57 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 16:58 [Qemu-devel] [PATCH v2 00/11] Memory patches, part 4: region ownership Paolo Bonzini
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 01/11] memory: add owner argument to initialization functions Paolo Bonzini
2013-07-01 23:16 ` Andreas Färber
2013-07-01 23:20 ` Andreas Färber
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 02/11] memory: destroy phys_sections one by one Paolo Bonzini
2013-07-01 14:14 ` Jan Kiszka
2013-07-01 14:32 ` Paolo Bonzini
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 03/11] exec: simplify destruction of the phys map Paolo Bonzini
2013-07-01 14:23 ` Jan Kiszka
2013-07-01 14:33 ` Paolo Bonzini
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 04/11] memory: add getter for owner Paolo Bonzini
2013-07-01 14:24 ` Jan Kiszka
2013-07-01 14:35 ` Paolo Bonzini
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 05/11] memory: add ref/unref Paolo Bonzini
2013-07-01 14:29 ` Jan Kiszka
2013-07-01 14:38 ` Paolo Bonzini
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls Paolo Bonzini
2013-07-01 18:33 ` Jan Kiszka
2013-07-02 6:42 ` Paolo Bonzini
2013-07-02 7:11 ` Jan Kiszka
2013-07-02 8:18 ` Paolo Bonzini
2013-07-02 8:36 ` Jan Kiszka
2013-07-02 9:28 ` Paolo Bonzini
2013-07-02 9:31 ` Jan Kiszka
2013-07-02 9:57 ` Paolo Bonzini [this message]
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host Paolo Bonzini
2013-07-01 18:33 ` Jan Kiszka
2013-07-01 20:48 ` Paolo Bonzini
2013-07-02 7:09 ` Jan Kiszka
2013-07-02 7:52 ` Paolo Bonzini
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 08/11] exec: move qemu_ram_addr_from_host_nofail to cputlb.c Paolo Bonzini
2013-07-01 18:34 ` Jan Kiszka
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 09/11] memory: return MemoryRegion from qemu_ram_addr_from_host Paolo Bonzini
2013-07-01 18:34 ` Jan Kiszka
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 10/11] exec: reorganize address_space_map Paolo Bonzini
2013-07-01 18:34 ` Jan Kiszka
2013-07-01 20:44 ` Paolo Bonzini
2013-07-02 7:08 ` Jan Kiszka
2013-06-28 16:58 ` [Qemu-devel] [PATCH v2 11/11] memory: ref/unref memory across address_space_map/unmap Paolo Bonzini
2013-07-01 18:37 ` Jan Kiszka
2013-07-01 8:43 ` [Qemu-devel] [PATCH v2 00/11] Memory patches, part 4: region ownership Jan Kiszka
2013-07-01 9:04 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2A3FD.3090702@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.