From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
Juan Quintela <quintela@redhat.com>, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks
Date: Tue, 02 Jul 2013 12:51:14 +0200 [thread overview]
Message-ID: <51D2B0A2.1080606@redhat.com> (raw)
In-Reply-To: <20130702074038.GD6800@stefanha-thinkpad.redhat.com>
Il 02/07/2013 09:40, Stefan Hajnoczi ha scritto:
> On Mon, Jul 01, 2013 at 05:55:15PM +0200, Peter Lieven wrote:
>>
>> Am 01.07.2013 um 16:13 schrieb Stefan Hajnoczi <stefanha@redhat.com>:
>>
>>> On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote:
>>>
>>> This patch breaks cross-version blog migration. We need to control
>>> whether or not to use the new BLK_MIG_FLAG_ZERO_BLOCK flag.
>>
>> you are right the upgrade way works, but downgrade not. what is the
>> proposed way to fix this?
>
> The safest way is to add a block migration flag that toggles the zero
> block. By default it would be off.
>
> Maybe you would also add a MigrationCapability in qapi-schema.json to
> indicated that zero blocks are supported in block migration. That would
> allow management tools to ask QEMU on both sides if they support zero
> blocks.
>
> Use migrate-set-capabilities to enable the zero block feature.
Yes, a capability makes sense.
Paolo
next prev parent reply other threads:[~2013-07-02 10:51 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 13:11 [Qemu-devel] [PATCHv2 00/11] iscsi/qemu-img/block-migration enhancements Peter Lieven
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 01/11] iscsi: add logical block provisioning information to iscsilun Peter Lieven
2013-07-01 13:35 ` Stefan Hajnoczi
2013-07-01 16:08 ` Peter Lieven
2013-07-10 9:19 ` Kevin Wolf
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 02/11] iscsi: read unmap info from block limits vpd page Peter Lieven
2013-07-03 3:43 ` ronnie sahlberg
2013-07-03 21:23 ` Peter Lieven
2013-07-04 12:37 ` Paolo Bonzini
2013-07-04 21:07 ` Peter Lieven
2013-07-05 6:28 ` Paolo Bonzini
2013-07-05 7:11 ` ronnie sahlberg
2013-07-06 22:15 ` Peter Lieven
2013-07-06 23:23 ` ronnie sahlberg
2013-07-10 9:23 ` Kevin Wolf
2013-07-10 9:25 ` Kevin Wolf
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 03/11] iscsi: add bdrv_co_is_allocated Peter Lieven
2013-07-01 13:46 ` Stefan Hajnoczi
2013-07-01 16:00 ` Peter Lieven
2013-07-10 9:41 ` Kevin Wolf
2013-07-10 13:49 ` Peter Lieven
2013-07-10 14:43 ` Kevin Wolf
2013-07-10 14:49 ` Peter Lieven
2013-07-10 14:54 ` Kevin Wolf
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 04/11] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-07-10 9:54 ` Kevin Wolf
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 05/11] block: add bdrv_write_zeroes() Peter Lieven
2013-07-10 9:56 ` Kevin Wolf
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 06/11] block/raw: add bdrv_co_write_zeroes Peter Lieven
2013-07-10 9:57 ` Kevin Wolf
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 07/11] iscsi: let bdrv_create conditionally zero out the device Peter Lieven
2013-07-01 13:58 ` Stefan Hajnoczi
2013-07-01 20:20 ` Paolo Bonzini
2013-07-01 21:36 ` Peter Lieven
2013-07-02 9:22 ` Paolo Bonzini
2013-07-02 10:36 ` Peter Lieven
2013-07-02 10:49 ` Paolo Bonzini
2013-07-02 10:56 ` Peter Lieven
2013-07-02 11:04 ` Paolo Bonzini
2013-07-02 11:18 ` Peter Lieven
2013-07-10 10:14 ` Kevin Wolf
2013-07-10 13:52 ` Peter Lieven
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks Peter Lieven
2013-07-01 14:13 ` Stefan Hajnoczi
2013-07-01 15:55 ` Peter Lieven
2013-07-02 7:40 ` Stefan Hajnoczi
2013-07-02 10:51 ` Paolo Bonzini [this message]
2013-07-01 16:09 ` Peter Lieven
2013-07-02 7:36 ` Stefan Hajnoczi
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 09/11] iscsi: factor out sector conversions Peter Lieven
2013-07-10 11:29 ` Kevin Wolf
2013-07-10 14:07 ` Peter Lieven
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported Peter Lieven
2013-07-10 11:33 ` Kevin Wolf
2013-07-10 14:04 ` Peter Lieven
2013-07-10 14:28 ` Kevin Wolf
2013-07-10 14:49 ` Peter Lieven
2013-07-10 14:58 ` Kevin Wolf
2013-07-10 20:31 ` Peter Lieven
2013-06-27 13:11 ` [Qemu-devel] [PATCHv2 11/11] iscsi: assert that sectors are aligned to LUN blocksize Peter Lieven
2013-07-01 14:35 ` Stefan Hajnoczi
2013-07-01 15:59 ` Peter Lieven
2013-07-02 7:44 ` Stefan Hajnoczi
2013-07-02 8:28 ` Peter Lieven
2013-07-02 10:44 ` Paolo Bonzini
2013-07-02 10:49 ` Peter Lieven
2013-07-02 10:53 ` Paolo Bonzini
2013-07-10 11:38 ` Kevin Wolf
2013-07-10 14:02 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2B0A2.1080606@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.