From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <51D2BCE5.8060602@free-electrons.com> Date: Tue, 02 Jul 2013 13:43:33 +0200 From: Alexandre Belloni MIME-Version: 1.0 To: Marek Vasut CC: linux-iio@vger.kernel.org, otavio@ossystems.com.br, Jonathan Cameron , Fabio Estevam Subject: Re: [PATCH] iio: mxs-lradc: Remove useless check in read_raw References: <1372723722-13902-1-git-send-email-marex@denx.de> In-Reply-To: <1372723722-13902-1-git-send-email-marex@denx.de> Content-Type: text/plain; charset=UTF-8 List-ID: Dear Marek, I don't seem to be hitting that issue. I'm using 3.10rc7. Do you know how to reproduce it ? Regards, On 02/07/2013 02:08, Marek Vasut wrote: > The removed check in the read_raw implementation was always true, > therefore remove it. > > Signed-off-by: Marek Vasut > Cc: Jonathan Cameron > Cc: Fabio Estevam > --- > drivers/staging/iio/adc/mxs-lradc.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c > index d92c97a..c318eb6 100644 > --- a/drivers/staging/iio/adc/mxs-lradc.c > +++ b/drivers/staging/iio/adc/mxs-lradc.c > @@ -234,7 +234,6 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev, > { > struct mxs_lradc *lradc = iio_priv(iio_dev); > int ret; > - unsigned long mask; > > if (m != IIO_CHAN_INFO_RAW) > return -EINVAL; > @@ -243,12 +242,6 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev, > if (chan->channel > LRADC_MAX_TOTAL_CHANS) > return -EINVAL; > > - /* Validate the channel if it doesn't intersect with reserved chans. */ > - bitmap_set(&mask, chan->channel, 1); > - ret = iio_validate_scan_mask_onehot(iio_dev, &mask); > - if (ret) > - return -EINVAL; > - > /* > * See if there is no buffered operation in progess. If there is, simply > * bail out. This can be improved to support both buffered and raw IO at > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com