From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtzvE-0001TP-77 for qemu-devel@nongnu.org; Tue, 02 Jul 2013 08:43:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtzvC-0006Th-Ao for qemu-devel@nongnu.org; Tue, 02 Jul 2013 08:43:04 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45858 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtzvC-0006TE-43 for qemu-devel@nongnu.org; Tue, 02 Jul 2013 08:43:02 -0400 Message-ID: <51D2CAD0.7090309@suse.de> Date: Tue, 02 Jul 2013 14:42:56 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1372513646-6053-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1372513646-6053-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] spapr: Fix compiler warnings for some versions of gcc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Paolo Bonzini , qemu-devel , David Gibson On 06/29/2013 03:47 PM, Stefan Weil wrote: > i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports these warnings: > > hw/ppc/spapr_hcall.c:188:1: warning: > control reaches end of non-void function [-Wreturn-type] > > hw/ppc/spapr_pci.c:454:1: warning: > control reaches end of non-void function [-Wreturn-type] > > Both warnings are fixed by using g_assert_not_reached instead of assert. > A second line with assert(0) in spapr_pci.c which did not raise a compiler > warning was modified, too, because g_assert_not_reached documents the > purpose of that statement and is not removed in release builds. > > Signed-off-by: Stefan Weil Thanks, applied to ppc-next. Alex