From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utzxp-0004ZJ-FH for qemu-devel@nongnu.org; Tue, 02 Jul 2013 08:45:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Utzxn-0007eG-9a for qemu-devel@nongnu.org; Tue, 02 Jul 2013 08:45:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46075 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utzxn-0007dq-2w for qemu-devel@nongnu.org; Tue, 02 Jul 2013 08:45:43 -0400 Message-ID: <51D2CB74.2020709@suse.de> Date: Tue, 02 Jul 2013 14:45:40 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1372096130-24994-1-git-send-email-sw@weilnetz.de> <1372096130-24994-2-git-send-email-sw@weilnetz.de> In-Reply-To: <1372096130-24994-2-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] spapr: Use named enum for function remove_hpte List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel , David Gibson On 06/24/2013 07:48 PM, Stefan Weil wrote: > The function returned a target_ulong which was made from unnamed enum > values. The target_ulong was then assigned to an int variable which > was used in a switch statement. > > Using a named enum in both cases makes reviews easier. > > Signed-off-by: Stefan Weil Thanks, applied to ppc-next. Alex